[High] Hide the Trip Room from NewDot unless you are on the newDotTravel beta

[stitesExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:. n/a
Email or phone of affected tester (no customers): all users on travel beta
Logs: https://stackoverflow.com/c/expensify/questions/4856 n/a
Expensify/Expensify Issue URL: n/a
Issue reported by: @stitesExpensify
Slack conversation: https://expensify.slack.com/archives/C05S5EV2JTX/p1728320141565859

Problem

We are currently focused on travel for OldDot, and have put all NewDot features on hold. We are also not testing travel on NewDot. For this reason, we want to hide the trip room and any other travel related features behind a beta except for the main booking flow.

The name of the beta is BETA_NEW_TRAVEL_PROVISIONING = 'newTravelProvisioning';

Expected Result:

Users should be able to book a trip via newdot (clicking "book travel" and being brought to Spotnana), but they should not see the trip room or any other travel related features.

Workaround:

Users can still use NewDot, it just looks bad and has bugs

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[stitesExpensify]

@shubham1206agra any interest on doing this one since you have been working on trip rooms already?

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[shubham1206agra]

I will do this

[DylanDylann]

@shubham1206agra Any update here?

[rushatgabhane]

picking this up for implementation - https://expensify.enterprise.slack.com/archives/C02NK2DQWUX/p1729059159601299?thread_ts=1729059159.601299&cid=C02NK2DQWUX

[shubham1206agra]

Sorry, right now I am busy. I am really sorry for the delay in reassignment.

[DylanDylann]

@rushatgabhane Any update here?

[rushatgabhane]

hey, there are many changes.

Question: should we hide travel from search too??

[twisterdotcom]

How do you mean? Like here?

If so, no we don't need to. This amalgamtes all trips we scan, not just trips booked via Expensify Travel. It's sort of separate.

[melvin-bot]

@twisterdotcom, @rushatgabhane, @stitesExpensify, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

[twisterdotcom]

How is this going then @rushatgabhane?

[rushatgabhane]

PR above ^

@twisterdotcom few questions.
If we show the trip in search, then we can still navigate to the trip room by going up the parent threads.
Is this okay?

Screen.Recording.2024-10-24.at.04.40.18.mov

[trjExpensify]

👋 @stitesExpensify @Gonals @twisterdotcom @rlinoz - can we kill the newDotSpotnanaTravel beta so the "Book travel" menu item shows again, now that we're building a new beta here to hide the trip rooms only?

This will help with some HybridApp development to action on the redirect when they click the Travel tab in OldApp.

[twisterdotcom]

If we show the trip in search, then we can still navigate to the trip room by going up the parent threads.
Is this okay?

I think this should be fine for now.

[rushatgabhane]

but those rooms and transactions shouldn't be visible in LHN and such, right?

[rlinoz]

It doesn't look like we are using the newDotSpotnanaTravel beta anywhere https://github.com/search?q=org%3AExpensify+newDotSpotnanaTravel+OR+BETA_NEWDOT_SPOTNANA_TRAVEL&type=code

Am I missing something?

[trjExpensify]

Hm, why is that in Betatify then? 😅 Issue here: https://github.com/Expensify/Expensify/issues/432172

Edit: If it's unused, let's kill it so it's not confusing us.

[rlinoz]

Ah I see, I think we never implemented it in the App though, from what I can tell we are hiding the button based on spotnanaTravel beta, which is the same beta we use for the OldApp

App/src/libs/Permissions.ts

Lines 23 to 25 in 989542b

	function canUseSpotnanaTravel(betas: OnyxEntry<Beta[]>): boolean {
	return !!betas?.includes(CONST.BETAS.SPOTNANA_TRAVEL) || canUseAllBetas(betas);
	}

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Lines 448 to 454 in f992436

	...(canUseSpotnanaTravel
	? [
	{
	icon: Expensicons.Suitcase,
	text: translate('travel.bookTravel'),
	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.TRAVEL_MY_TRIPS)),
	},

[trjExpensify]

Ah okay, the Book travel menu item is being hidden based on canUseSpotnanaTravel which is the overall beta for Travel I take it on both OldDot and NewDot?

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Lines 448 to 453 in d78be88

	...(canUseSpotnanaTravel
	? [
	{
	icon: Expensicons.Suitcase,
	text: translate('travel.bookTravel'),
	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.TRAVEL_MY_TRIPS)),

@mateuuszzzzz, if that's the case. I think we should have that accessible in OldApp to use? Ted, Rodrigo.. can you confirm what the expected behaviour with this spotnanaTravel beta? Is it:

• When not on the beta: Clicking the Trips Travel tab on OldApp doesn't redirect, it opens the OldApp Trips page.
• When on the beta: Clicking the Travel tab redirects to NewDot's book travel flow

[trjExpensify]

Ah I see, I think we never implemented it in the App though, from what I can tell we are hiding the button based on spotnanaTravel beta, which is the same beta we use for the OldApp

Jinxxxxxx

[DylanDylann]

@rushatgabhane Any update?

[melvin-bot]

@twisterdotcom, @rushatgabhane, @stitesExpensify, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@twisterdotcom, @rushatgabhane, @stitesExpensify, @DylanDylann Still overdue 6 days?! Let's take care of this!

[DylanDylann]

@rushatgabhane Kindly bump

[melvin-bot]

@twisterdotcom, @rushatgabhane, @stitesExpensify, @DylanDylann 12 days overdue now... This issue's end is nigh!

[melvin-bot]

@twisterdotcom, @rushatgabhane, @stitesExpensify, @DylanDylann 12 days overdue. Walking. Toward. The. Light...

[stitesExpensify]

Hey @rushatgabhane looks like it's been 2 weeks, can you provide an update please?

[melvin-bot]

This issue has not been updated in over 14 days. @twisterdotcom, @rushatgabhane, @stitesExpensify, @DylanDylann eroding to Weekly issue.

[shubham1206agra]

@stitesExpensify @twisterdotcom Should we close this issue?
Since we now have FE issues off hold, it will be worked on.
And we no longer need a beta to hide the trip room.

[twisterdotcom]

I think that makes sense.