[HOLD for payment 2024-10-30] QBD - Empty link in RHP when network is disconnected while QBD setup is loading

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.47-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #50216
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Accounting.
3. Click Connect next to Quickbooks desktop
4. While RHP is loading, quickly disconnect network.

Expected Result:

RHP will show that the page is offline.

Actual Result:

RHP is loaded with empty link.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6630106_1728513620793.20241010_063732.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[hoangzinh]

The project is still in beta so I don't think it's a DB.

[hoangzinh]

cc @ZhenjaHorbach @lakchote ^

[ZhenjaHorbach]

It's not really clear what the expected result is
Should we show infinite loading
Or show separate screen to not show empty link

[lakchote]

The project is still in beta so I don't think it's a DB.

It's not a blocker as it's behind beta indeed.

[lakchote]

It's not really clear what the expected result is Should we show infinite loading Or show separate screen to not show empty link

I'd prefer to not show infinite loading when offline, as it would mistakenly make the user think something is going to happen and the link will show. We should find a way to notify him he's offline, and as such, cannot get the setup link.

Let's tag @Expensify/design to see if we already had to handle this situation before, and to have their point of view.

[dannymcclain]

Yeah I agree with not showing a loader forever—that doesn't seem super helpful.

Here are a couple ideas about how to handle this:

1) Replace the link with an offline indicator

If we can automatically update the link box with the link when it's available, this feels like the smoothest option.

2) Blast 'em with our blocking offline pattern

If we can't automatically update the link/we actually need them to just try again once they come back online, this pattern might work best.

cc @dubielzyk-expensify for thoughts and preferences.

[hoangzinh]

2nd idea looks promising to me 👀

[dubielzyk-expensify]

I think the 2nd idea just for the simplicity and consistency 👍

[strepanier03]

I think the 2nd makes it really clear but the 1st one looks more friendly.

[ZhenjaHorbach]

@lakchote @dannymcclain
About this issue

If we already have setupLink
Do we need to show OfflineBlockingView on full screen when user is offline ?

[dannymcclain]

🤔 Hmm, I don't think we do if we already have the link. Obviously the user might run into problems opening the link if they're truly offline, but IMO that's not really on us. Open to other perspectives though!

[hoangzinh]

I don't think we do if we already have the link

Yes, I have same thought.

[lakchote]

@ZhenjaHorbach, I agree with @dannymcclain and @hoangzinh.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [QBD] Offline mode for RequireQuickBooksDesktopModal #50915

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment (Needs manual offer from BZ)
• @ZhenjaHorbach requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh / @ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh / @ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@hoangzinh / @ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hoangzinh owed $250 via NewDot
• ROLE: @ZhenjaHorbach paid $250 via Upwork (offer)

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[strepanier03]

@ZhenjaHorbach @hoangzinh - Please complete the checklist. I will send the manual offer now but I won't be able to pay them out until the checklist is complete.

[strepanier03]

Payment Summary

• $250 - @hoangzinh via NewDot
• $250 - @ZhenjaHorbach via Upwork (offer)

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: No offending PR, it's new requirement for QBD project
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: I think it's a minor edge-case UI issue. I don't think we need a regression test for this bug.

[strepanier03]

@ZhenjaHorbach - I've paid and closed in Upwork, thanks!

@hoangzinh - the payment summary is here feel free to request payment now.

[melvin-bot]

@strepanier03 @lakchote Be sure to fill out the Contact List!

[garrettmknight]

$250 approved for @hoangzinh

[kiwiteaorion]

hi everyone, so far as i have seen, the empty screen is the result of the QuickBooks Desktop connection flow's improper handling of offline situations in the RHP. We should use offline detection, gentle fallbacks, and appropriate network state management to fix the issue. This includes including an isOnline status check, providing relevant offline messages, and preserving the connection link state even in the event of network outages. This approach avoids the loading flash problems that are currently seen and assures a consistent user experience!

[melvin-bot]

📣 @kiwiteaorion! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[kiwiteaorion]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01f52eea1fea1d62da?mp_source=share

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!