[HOLD for payment 2024-11-01] [$250] Inconsistent spacing between Add rate and Settings buttons in Distance rates and Taxes page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.47-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings
3. Go to Distance rates
4. Go to Taxes
5. Note the spacing difference between Add rate and Settings buttons on both pages

Expected Result:

The spacing between Add rate and Settings buttons should be the same on Distance rates and Taxes page

Actual Result:

The spacing between Add rate and Settings buttons is larger on Taxes than Distance rates

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6630487_1728550808617.20241010_165525.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844581573549819097
• Upwork Job ID: 1844581573549819097
• Last Price Increase: 2024-10-11
• Automatic offers:
• suneox | Reviewer | 104514529
• etCoderDysto | Contributor | 104514537

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[etCoderDysto]

Edited by proposal-police: This proposal was edited at 2024-10-10 14:01:40 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent spacing between Add rate and Settings buttons in Distance rates and Taxes page

What is the root cause of that problem?

On Distance Rates page we use, styles.gap2 to add margin between the buttons

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Line 239 in 175af25

<View style={[styles.w100, styles.flexRow, styles.gap2, shouldUseNarrowLayout && styles.mb3]}>

On Tax rates page we are using styles.mr3

App/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx

Line 228 in 175af25

style={[styles.mr3, shouldUseNarrowLayout && styles.flex1]}

What changes do you think we should make in order to solve the problem?

We can change styles.mr3 and styles.gap2 to matching values. Example styles.mr2and styles.gap2.

What alternative solutions did you explore? (Optional)

We can remove styles.mr3 from here and apply styles.gap2 on the parent view container here in the same way as Distance Rates page .

Note we should check for other places where those buttons are used, and apply the same change

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021844581573549819097

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[suneox]

The alternative solution from @etCoderDysto LGTM

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@suneox, @grgia, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

[etCoderDysto]

A kind reminder for assignment 🙇🏻‍♂️

[kadiealexander]

@grgia bump on this!

[melvin-bot]

@suneox, @grgia, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @etCoderDysto 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[grgia]

Thanks for your patience, I was OOO.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Inconsistent spacing between Add rate and Settings buttons in Distance rates and Taxes page #51171

If no regressions arise, payment will be issued on 2024-11-01. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Reviewer)
• @etCoderDysto requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@suneox] The PR that introduced the bug has been identified. Link to the PR:
• [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@suneox] Determine if we should create a regression test for this bug.
• [@suneox] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kadiealexander]

Reassigning for someone to handle payment as I'm OOO for the next two weeks.

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[suneox]

Checklist

• [@suneox] The PR that introduced the bug has been identified. Link to the PR: [Simplified Collect][Taxes] Create WorkspaceTaxesPage #37870
• [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment
• [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@suneox] Determine if we should create a regression test for this bug: N/A
• [@suneox] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[greg-schroeder]

Paid!

[melvin-bot]

@greg-schroeder @grgia Be sure to fill out the Contact List!