[Supportal] Allow full visibility into #admins room chats and show in LHN

[stephanieelliott]

Version Number:
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: LOGS
Expensify/Expensify Issue URL: N/A
Issue reported by: @stephanieelliott
Slack conversation: https://expensify.slack.com/archives/C07NZ8B1VTQ/p1728500635598069

Action Performed:

1. Support log into a customer account (must be: owner on workspace)
2. Click New Expensify
3. See LHN fails to load #admins room

Expected Result:

#admins rooms should show in LHN

Actual Result:

#admins room does not show in LHN

Workaround:

None

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

MissingAdminRoom.mp4

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

[mallenexpensify]

Looks like we're awaiting an internal engineer. Not sure what I can/should do here.

[melvin-bot]

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

[mallenexpensify]

Kinda/sorta waiting on this too

• [Supportal] Workspace expense does not load when clicked #50627 (comment)

[melvin-bot]

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

[marcaaron]

They can't be seen because of this line here https://github.com/Expensify/Auth/blob/e92662e740063086376c2dc0a7a1d49bd43fc5ee/auth/command/OpenApp.cpp#L135 which seems intentional based on https://github.com/Expensify/Auth/pull/10366 and https://github.com/Expensify/Expensify/issues/380658

Is there not a privacy and security issue around showing the #admins room?

[mallenexpensify]

Thanks for 👀 @marcaaron

Support log into a customer account (must be: owner on workspace)

From the high level, would/should the owner of a workspace be able to see all #admin channel? I would think so.
Then.. for supportal, would/should we also want to be able to view that because the owner who we're supportaled into can view it?

I do remember there being discussions a while back about which reports others would allowed to view. I'm guessing we wouldn't Slack employees to easily view details from our #directors channel in Slack.

[marcaaron]

The owner of the workspace should see the admin channel because they would be an admin too.

for supportal, would/should we also want to be able to view that because the owner who we're supportaled into can view it

Why did we redact it in the first place? I can't think of any reason why we need this from a support perspective. But maybe not understanding why we want this 😄

[mallenexpensify]

@stephanieelliott , why do we want employees to be able to supportal into #admin rooms?

[melvin-bot]

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

[stephanieelliott]

I don't think we intentionally redacted the #admins room, however it probably was an unintended consequence of one of those PRs to redact chats. But CAM, SRAM and Guides are all in their assigned customers #admins rooms already, I don't think there is any expectation of privacy there. The #admins room is where we send most of our account management comms. And most importantly it's where we display the workspace audit trails in ND, which we do need for troubleshooting.

Opening up Supportal access allows anyone (not just the assigned Guide/AM) to view the conversation history and workspace logs.

This was recently discussed as part of a pre-design here where we agreed we should make the #admins room visible in its entirety.

[marcaaron]

This one is now just waiting on an Auth deploy.

[mallenexpensify]

I'm back from OOO on Nov 14th, not assigning another BZ cuz it doesn't BZ-related actions here. Will review once back.

[melvin-bot]

@mallenexpensify, @marcaaron Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@mallenexpensify, @marcaaron 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[marcaaron]

I think we can close this out now.