Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] LHN- LHN shows "This chat is with..." instead of last message if deleting thread message #50685

Closed
3 of 6 tasks
IuliiaHerets opened this issue Oct 12, 2024 · 24 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5074346&group_by=cases:section_id&group_order=asc&group_id=292106
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Open a chat with some messages displayed.
  3. Right click over the last message.
  4. Click on "Reply in Thread"
  5. Send any message in thread chat.
  6. Delete the just sent reply.
  7. Return to the first chat.
  8. Delete the recently threaded message.
  9. Verify that chat preview in LHN now displays the previous message.

Expected Result:

When deleting the last message of a chat, the chat preview in LHN, should display the previous message.

Actual Result:

When deleting a threaded message, displayed last in a chat conversation, the chat preview shows "This chat is with user" instead of the previous message in chat.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6632524_1728707238209.Thread_Delete.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021846016204171199063
  • Upwork Job ID: 1846016204171199063
  • Last Price Increase: 2024-10-22
Issue OwnerCurrent Issue Owner: @AndrewGable
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 12, 2024
@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

Copy link

melvin-bot bot commented Oct 12, 2024

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
@RachCHopkins
Copy link
Contributor

Easy to repro. External as far as I can tell!

image

@melvin-bot melvin-bot bot removed the Overdue label Oct 15, 2024
@RachCHopkins RachCHopkins added the External Added to denote the issue can be worked on by a contributor label Oct 15, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021846016204171199063

@melvin-bot melvin-bot bot changed the title LHN- LHN shows "This chat is with..." instead of last message if deleting thread message [$250] LHN- LHN shows "This chat is with..." instead of last message if deleting thread message Oct 15, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 15, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

@huult
Copy link
Contributor

huult commented Oct 15, 2024

This is a backend issue. lastMessageText returns an empty string when the message is deleted.

  • Screenshot 2024-10-15 at 13 54 05
  • Screenshot 2024-10-15 at 13 54 25

@paultsimura
Copy link
Contributor

Thanks @huult, looks like a BE issue indeed.

🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Oct 15, 2024

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@muttmuure muttmuure moved this to MEDIUM in [#whatsnext] #quality Oct 15, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

@AndrewGable, @paultsimura, @RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2024
@RachCHopkins
Copy link
Contributor

@AndrewGable can you take a gander at this please?

@Shahidullah-Muffakir
Copy link
Contributor

Seems like resolved, I couldn't reproduce it.

@RachCHopkins
Copy link
Contributor

@paultsimura can you confirm?

@paultsimura
Copy link
Contributor

Still reproducible on Staging, definitely a BE issue:

image

@melvin-bot melvin-bot bot removed the Overdue label Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Oct 25, 2024

@AndrewGable, @paultsimura, @RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
Copy link

melvin-bot bot commented Oct 26, 2024

@AndrewGable @paultsimura @RachCHopkins this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@RachCHopkins RachCHopkins removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Oct 29, 2024
@RachCHopkins
Copy link
Contributor

@AndrewGable can you please take a look?

@RachCHopkins RachCHopkins added the Internal Requires API changes or must be handled by Expensify staff label Oct 29, 2024
@muttmuure
Copy link
Contributor

Is this really unexpected? I am curious why we feel like we should change this behavior

@muttmuure
Copy link
Contributor

I vote we close this

Copy link

melvin-bot bot commented Oct 29, 2024

@AndrewGable, @paultsimura, @RachCHopkins 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@RachCHopkins
Copy link
Contributor

@AndrewGable do you agree that this should be closed?

@AndrewGable
Copy link
Contributor

Yes!

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2024
@github-project-automation github-project-automation bot moved this from MEDIUM to Done in [#whatsnext] #quality Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

@AndrewGable @RachCHopkins Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
Development

No branches or pull requests

7 participants