-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LHN Mismatch] LHN falls out of sync between devices due to incomplete data in mergeCollection #50696
Comments
Triggered auto assignment to @johncschuster ( |
Triggered auto assignment to @Beamanator ( |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
Job added to Upwork: https://www.upwork.com/jobs/~021845644254812409536 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
Adam from Callstack, I'd like to work on this. |
Do we have a high level plan for this? Do we think this data would be received on reconnect or via push? Either way this seems like a backend issue to me. |
I think the lastUpdatedTime should be sent as onyxUpdate, but we are not processing them when the client is not active, so this might be another reason to implement the background processing. But even when you come back online, we should get the missed Onyx updates and apply them. So what an external person can do imho is they can help diagnose if we get the updates but we fail to apply them for some reason or we just do not get the updates at all |
We've tested this across 2 accounts together with @rinej, here's what we know:
This leads to this data just not coming through to the mobile client, the desktop client is not able to push it through. Requests are being added correctly, so background processing will help as you don't need to reopen the app to walk through the queue. |
@Beamanator, @johncschuster, @Ollyws, @adhorodyski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Just passing through here, but what does it mean to "jam the queue"? Is there a step-by-step reproduction that can be provided? |
Bumping for Melv. Thanks for the clarifying question, @marcaaron! |
@puneetlath, @johncschuster, @Ollyws, @adhorodyski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Continuing to make progress. Getting closer. |
Thanks for the update, @puneetlath! (Bumping to keep Melvin at bay) |
Getting very close, but not quite there yet. |
@puneetlath, @johncschuster, @Ollyws, @adhorodyski Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Same update. Getting very close, but not quite there yet. |
@puneetlath, @johncschuster, @Ollyws, @adhorodyski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Web PR has been merged. Will add some users to the beta as soon as it's on staging. |
Beta seems to be working well. Going to most likely roll this out to all internal employees today. |
@puneetlath, @johncschuster, @Ollyws, @adhorodyski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
All internal employees are now on the beta. Working on getting rid of the beta and moving to minimum app version next. Then I believe we should be done. |
Amazing! |
Closing this out as we should be done here. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1728692784614339?thread_ts=1724780554.260709&cid=C05LX9D6E07
Action Performed:
Precondition: Close or background the mobile
Expected Result:
Message should display as "read"
Actual Result:
Message is displayed as "unread"
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: