Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LHN Mismatch] LHN falls out of sync between devices due to incomplete data in mergeCollection #50696

Closed
1 of 6 tasks
m-natarajan opened this issue Oct 14, 2024 · 40 comments
Closed
1 of 6 tasks
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed

Comments

@m-natarajan
Copy link

m-natarajan commented Oct 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1728692784614339?thread_ts=1724780554.260709&cid=C05LX9D6E07

Action Performed:

Precondition: Close or background the mobile

  1. Send a message from account A to account B
  2. View and read that report in Desktop
  3. Open the report in mobile app

Expected Result:

Message should display as "read"

Actual Result:

Message is displayed as "unread"

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021845644254812409536
  • Upwork Job ID: 1845644254812409536
  • Last Price Increase: 2024-10-14
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 14, 2024
Copy link

melvin-bot bot commented Oct 14, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@m-natarajan m-natarajan added the AutoAssignerNewDotQuality Used to assign quality issues to engineers label Oct 14, 2024
Copy link

melvin-bot bot commented Oct 14, 2024

Triggered auto assignment to @Beamanator (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added the Weekly KSv2 label Oct 14, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Oct 14, 2024
Copy link

melvin-bot bot commented Oct 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021845644254812409536

@melvin-bot melvin-bot bot changed the title Messages read on desktop are not marked as read on mobile, if the mobile app is closed/backgrounded when it happens [$250] Messages read on desktop are not marked as read on mobile, if the mobile app is closed/backgrounded when it happens Oct 14, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 14, 2024
Copy link

melvin-bot bot commented Oct 14, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 14, 2024
@adhorodyski
Copy link
Contributor

Adam from Callstack, I'd like to work on this.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 14, 2024
@mountiny mountiny moved this to CRITICAL in [#whatsnext] #quality Oct 14, 2024
@Julesssss
Copy link
Contributor

Do we have a high level plan for this?

Do we think this data would be received on reconnect or via push? Either way this seems like a backend issue to me.

@mountiny
Copy link
Contributor

I think the lastUpdatedTime should be sent as onyxUpdate, but we are not processing them when the client is not active, so this might be another reason to implement the background processing.

But even when you come back online, we should get the missed Onyx updates and apply them. So what an external person can do imho is they can help diagnose if we get the updates but we fail to apply them for some reason or we just do not get the updates at all

@adhorodyski
Copy link
Contributor

We've tested this across 2 accounts together with @rinej, here's what we know:

  • Anytime we're sure the queue is empty, we cannot reproduce this issue. I've also tested this across NewDot and the Hybrid (testflight on iOS to see across platforms)
  • When we jam the queue, this issue starts getting reproducible. With mobile app turned off, reading a message on desktop does not produce a 'read' status on mobile when opening the app.

This leads to this data just not coming through to the mobile client, the desktop client is not able to push it through. Requests are being added correctly, so background processing will help as you don't need to reopen the app to walk through the queue.

Copy link

melvin-bot bot commented Oct 17, 2024

@Beamanator, @johncschuster, @Ollyws, @adhorodyski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2024
@marcaaron
Copy link
Contributor

marcaaron commented Oct 17, 2024

When we jam the queue, this issue starts getting reproducible. With mobile app turned off, reading a message on desktop does not produce a 'read' status on mobile when opening the app.

Just passing through here, but what does it mean to "jam the queue"? Is there a step-by-step reproduction that can be provided?

@johncschuster
Copy link
Contributor

Bumping for Melv. Thanks for the clarifying question, @marcaaron!

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 14, 2024
Copy link

melvin-bot bot commented Nov 15, 2024

@puneetlath, @johncschuster, @Ollyws, @adhorodyski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@puneetlath
Copy link
Contributor

Continuing to make progress. Getting closer.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 15, 2024
@johncschuster
Copy link
Contributor

Thanks for the update, @puneetlath! (Bumping to keep Melvin at bay)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 18, 2024
@puneetlath
Copy link
Contributor

Getting very close, but not quite there yet.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 21, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

@puneetlath, @johncschuster, @Ollyws, @adhorodyski Whoops! This issue is 2 days overdue. Let's get this updated quick!

@puneetlath
Copy link
Contributor

Same update. Getting very close, but not quite there yet.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 25, 2024
Copy link

melvin-bot bot commented Nov 29, 2024

@puneetlath, @johncschuster, @Ollyws, @adhorodyski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@puneetlath
Copy link
Contributor

Web PR has been merged. Will add some users to the beta as soon as it's on staging.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 2, 2024
@puneetlath
Copy link
Contributor

Beta seems to be working well. Going to most likely roll this out to all internal employees today.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 5, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

@puneetlath, @johncschuster, @Ollyws, @adhorodyski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@puneetlath
Copy link
Contributor

All internal employees are now on the beta. Working on getting rid of the beta and moving to minimum app version next. Then I believe we should be done.

@melvin-bot melvin-bot bot removed the Overdue label Dec 9, 2024
@muttmuure
Copy link
Contributor

Amazing!

@melvin-bot melvin-bot bot added the Overdue label Dec 12, 2024
@puneetlath
Copy link
Contributor

Closing this out as we should be done here.

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed
Projects
Development

No branches or pull requests