[HOLD for payment 2024-11-07] Add phone number to the private personal details section

[mountiny]

Problem

Discussed in this thread

Users need a phone number to issue physical Expensify cards. We ask them for the phone number in the form to ship the Expensify card, but otherwise, this phone number is not editable from NewDot. This is a problem in case they want to edit it after adding it for the Expensify card.

Solution

Let's add the phone number row to the private personal details in Settings > Account where the other private account details live:

I am assigning Jon to this so he can get credits for the mocks.

Next steps:

• Web PR for a new command that will take in the phone number in 1:1:1 fashion, we are going to use the existing SetPrivatePersonalDetails command
• App PR to add a new page form to request the card and call the new api end point

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Current assignee @dubielzyk-expensify is eligible for the Design assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Current assignee @dubielzyk-expensify is eligible for the NewFeature assigner, not assigning anyone new.

[mountiny]

Keeping it weekly, I will create the API command

[NJ-2020]

@mountiny Just to make sure that you're open to proposals?

[mountiny]

@NJ-2020 No not, yet at least

[NJ-2020]

Thanks

[mountiny]

@DylanDylann @allgandalf the new command name is UpdatePhoneNumber and it takes authToken and the phoneNumber as params

[allgandalf]

Cool Cool, I will start working as soon as we have the mocks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Feature]: Add phone number to the private personal details section #50773

If no regressions arise, payment will be issued on 2024-11-07. 🎊

For reference, here are some details about the assignees on this issue:

• @allgandalf requires payment (Needs manual offer from BZ)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf / @DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[allgandalf]

@DylanDylann will fill the regression test for this I was the C, for the issue

[DylanDylann]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: New Feature
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to settings > profile
2. In private details, click on Phone Number
3. Verify that: you are able to enter phone number and styling is correct, and verify that error is displayed on wrong entry

Do we agree 👍 or 👎

[twisterdotcom]

@mountiny is this $250 each?

[mountiny]

@twisterdotcom correct, $250 each

[twisterdotcom]

Payment Summary:

• @DylanDylann paid $250 via Upwork here (C+)
• @allgandalf paid $250 via Upwork here (Contributor)