Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Avatars] - Fix ReportPreview Avatar Patterns #50763

Open
4 tasks
grgia opened this issue Oct 15, 2024 · 7 comments
Open
4 tasks

[Avatars] - Fix ReportPreview Avatar Patterns #50763

grgia opened this issue Oct 15, 2024 · 7 comments
Assignees

Comments

@grgia
Copy link
Contributor

grgia commented Oct 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Context

The ReportPreview Avatar code depends on BE or FE data depending on the report type. This has resulted in avatars and report preview headers breaking frequently.

The logic was nearly solved by this PR - #49172 which changed the logic to use the ownerID for reportPreviews as well as adding a calculation for This worked for all cases except the Send Money Flow where the ownerID is the payee, which is not the original actor.

Solution:

  • Define the rules for avatars as below and have design check them off
  • Define what data we need for avatars and send it in the reportpreview object (similar to how we send childReportActorID)
  • Send the avatar data from the BE and use that for the report preview case
  • Use this flow to create a UI-based test rail for these avatars / headers to prevent future regressions

View all open jobs on GitHub

@grgia grgia added the Daily KSv2 label Oct 15, 2024
@grgia grgia self-assigned this Oct 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

@grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@grgia grgia added Weekly KSv2 and removed Daily KSv2 labels Oct 21, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 21, 2024
@grgia
Copy link
Contributor Author

grgia commented Oct 21, 2024

Not overdue and not daily

@melvin-bot melvin-bot bot added the Overdue label Oct 29, 2024
@grgia
Copy link
Contributor Author

grgia commented Nov 1, 2024

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Nov 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@grgia
Copy link
Contributor Author

grgia commented Nov 11, 2024

^

@melvin-bot melvin-bot bot removed the Overdue label Nov 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2024
@grgia
Copy link
Contributor Author

grgia commented Nov 22, 2024

updated PR

@melvin-bot melvin-bot bot removed the Overdue label Nov 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
@grgia
Copy link
Contributor Author

grgia commented Dec 3, 2024

PR needs final update

@melvin-bot melvin-bot bot removed the Overdue label Dec 3, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 12, 2024
@grgia
Copy link
Contributor Author

grgia commented Dec 18, 2024

IOS build is broken

@melvin-bot melvin-bot bot removed the Overdue label Dec 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant