[HOLD for payment 2024-11-13] [$250] Header - Header does not display "No Action Required" when payment is disabled

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #49837
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com.
2. Navigate to Workspace and enable Workflows.
3. Disable payments.
4. Submit an expense in the workspace chat.
5. Go offline and click on the expense preview.

Expected Result:

The header should display "No further action required."

Actual Result:

The header displays "Waiting for your expense(s) to automatically submit."

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6635003_1728981428894.1__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021848784178852136813
• Upwork Job ID: 1848784178852136813
• Last Price Increase: 2024-10-22
• Automatic offers:
• dukenv0307 | Reviewer | 104641561
• NJ-2020 | Contributor | 104641563

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[NJ-2020]

Edited by proposal-police: This proposal was edited at 2024-10-16 03:35:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Header - Header does not display "No Action Required" when payment is disabled

What is the root cause of that problem?

When we create the next step header for the expense, we pass STATUS_NUM.OPEN for the predictedNextStatus

App/src/libs/actions/IOU.ts

Line 2170 in f737e9b

const optimisticNextStep = NextStepUtils.buildNextStep(iouReport, CONST.REPORT.STATUS_NUM.OPEN);

App/src/libs/NextStepUtils.ts

Lines 112 to 142 in f737e9b

	case CONST.REPORT.STATUS_NUM.OPEN:
	// Self review
	optimisticNextStep = {
	type,
	icon: CONST.NEXT_STEP.ICONS.HOURGLASS,
	message: [
	{
	text: 'Waiting for ',
	},
	{
	text: `${ownerDisplayName}`,
	type: 'strong',
	clickToCopyText: ownerAccountID === currentUserAccountID ? currentUserEmail : '',
	},
	{
	text: ' to ',
	},
	{
	text: 'add',
	},
	{
	text: ' %expenses.',
	},
	],
	};
	// Scheduled submit enabled
	if (harvesting?.enabled && autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL) {
	optimisticNextStep.message = [
	{
	text: 'Waiting for ',

What changes do you think we should make in order to solve the problem?

We should check if the policy?.reimbursementChoice is no CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO then we will pass STATUS_NUM.CLOSED

const optimisticNextStep = NextStepUtils.buildNextStep(
    iouReport,
    policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO ? CONST.REPORT.STATUS_NUM.CLOSED : CONST.REPORT.STATUS_NUM.OPEN,
);

Result

Screen.Recording.2024-10-15.at.06.10.29.mov

What alternative solutions did you explore? (Optional)

We can also hide the next step header when the reimbursementChoice is no as the backend return empty next step when the reimbursementChoice is no

const optimisticNextStep = policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO ? null : NextStepUtils.buildNextStep(
    iouReport,
    CONST.REPORT.STATUS_NUM.OPEN,
);

[OfstadC]

Can't reproduce. I don't get a header at all

[OfstadC]

Got in on the second try

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The header displays "Waiting for your expense(s) to automatically submit."

What is the root cause of that problem?

• When creating an expense, we always optimistically set the next step, assuming it will be CONST.REPORT.STATUS_NUM.OPEN, without accounting for the case where policy?.reimbursementChoice === 'reimburseNo':

App/src/libs/actions/IOU.ts

Line 2170 in f737e9b

const optimisticNextStep = NextStepUtils.buildNextStep(iouReport, CONST.REPORT.STATUS_NUM.OPEN);

• However, the backend returns an empty next step when policy?.reimbursementChoice === 'reimburseNo'.

What changes do you think we should make in order to solve the problem?

• Update:

App/src/libs/actions/IOU.ts

Line 2170 in f737e9b

const optimisticNextStep = NextStepUtils.buildNextStep(iouReport, CONST.REPORT.STATUS_NUM.OPEN);

to:

    const optimisticNextStep = policy?.reimbursementChoice === 'reimburseNo' ? null : NextStepUtils.buildNextStep(iouReport, CONST.REPORT.STATUS_NUM.OPEN);

to make sure our optimistic data will match BE data.

What alternative solutions did you explore? (Optional)

• Instead of set the optimistic next step to null like above, we can set it to:

{
    message: [],
    title: 'Next Step:',
    requiresUserAction: false,
    nextReceiver: '',
    showForExpense: true,
    showForMobile: true,
    showUndoSubmit: false
}

[daledah]

@OfstadC Can you confirm whether the expected behavior is: The header should display "No further action required."

Because, in online mode, there is no header is displayed.

[NJ-2020]

Proposal Updated

[abzokhattab]

I think this is a regression from #49837

[melvin-bot]

@OfstadC Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021848784178852136813

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[OfstadC]

The header shouldn't say "waiting to automatically submit..." since it's already been submitted. 😅

[dukenv0307]

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @mjasikowski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dukenv0307]

@mjasikowski @OfstadC I want to confirm the expectation here:

When creating the expense, we build the optimistic data for reportNextStep

App/src/libs/actions/IOU.ts

Line 2170 in f737e9b

const optimisticNextStep = NextStepUtils.buildNextStep(iouReport, CONST.REPORT.STATUS_NUM.OPEN);

and it's Waiting for your expense(s) to automatically submit.

But BE returns the empty message, so the header doesn't show anything

So what is the expectation here:

1. Header shows No further action required. (in the requirement)
2. Nothing is shown (like what BE returns)

[mjasikowski]

Let's go with @NJ-2020 proposal then!

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @NJ-2020 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@mjasikowski @OfstadC @NJ-2020 @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[NJ-2020]

PR ready
cc: @dukenv0307

[dukenv0307]

@mjasikowski @NJ-2020 BE returns the Waiting for your expense(s) to automatically submit messages (The correct message are No further action required.). Should we hold the issue for BE fix? IMO, the PR fix on FE side can be merged first

[mjasikowski]

I'll take a look and see if I can prepare a backend fix

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix no required action header does not display #51650

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

• @NJ-2020 requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Reviewer)

[melvin-bot]

@dukenv0307 @OfstadC The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• [] 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: There's no offending PR

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/443984

Regression Test Proposal

Test:

1. Go to staging.new.expensify.com.
2. Navigate to Workspace and enable Workflows.
3. Disable payments (Make or track payments option)
4. Submit an expense in the workspace chat.
5. Go offline and click on the expense preview.
6. Make sure the header displays "No further action required."

Do we agree 👍 or 👎

[OfstadC]

Thanks @dukenv0307 !

[OfstadC]

Will issue payment tomorrow

[OfstadC]

https://github.com/Expensify/Expensify/issues/443984

[OfstadC]

Payment Summary

• @NJ-2020 paid $250 via Upwork
• @dukenv0307 paid $250 via Upwork