[$250] Public Room-Join public Room while logged in by Gmail account doesn't lead to top

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5084026
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to http://www.staging.new.expensify.com/
   and login with new Gmail account (Not expensifail account)
2. While logged in, navigate to this link - https://staging.new.expensify.com/r/2091104345528462
3. Scroll up to check the top of the room conversation

Expected Result:

The Top of the conversation can be visible at first scroll up

Actual Result:

The Top of the conversation can not be visible at first scroll up. It shows the top after navigating back

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6635372_1729005580319.bandicam_2024-10-15_18-01-36-635.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846256728857446702
• Upwork Job ID: 1846256728857446702
• Last Price Increase: 2024-11-05

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021846256728857446702

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[allgandalf]

Waiting for proposals.......

[allgandalf]

Were you able to reproduce this one @puneetlath ?

[puneetlath]

Hmm, actually no. It works fine for me.

[puneetlath]

Oh wait, it specifically says as a gmail user. Let me try that.

[allgandalf]

crapp, missed that, I will test as well

[puneetlath]

It also worked fine for me with gmail account. What about you?

[allgandalf]

Works fine for me too, lets ask for a re-test? maybe poor connection at the testers end??

[izarutskaya]

Issue is still reproducible for tester, but only with gmail accounts
Build v 9.0.50-0

bandicam.2024-10-17.11-08-53-995.mp4

[puneetlath]

@izarutskaya is it any gmail account or only a specific one? We've tried with gmail accounts and haven't been able to reproduce.

[izarutskaya]

Tester can reproduce the issue with any gmail account
Account from this video [email protected]
Try please with this

bandicam.2024-10-17.19-28-29-670.mp4

[melvin-bot]

@puneetlath, @allgandalf Eep! 4 days overdue now. Issues have feelings too...

[allgandalf]

waiting for proposals...

[Anaslancer]

Edited by proposal-police: This proposal was edited at 2024-10-28 14:59:23 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Public Room-Join public Room while logged in by Gmail account doesn't lead to top

What is the root cause of that problem?

The FlatList component has this bug when the data is huge. When working with large datasets in FlatList, we should use optimize the FlatList.
maxToRenderPerBatch props to control the number of items rendered at once. default is 10. I set it as 5.
updateCellsBatchingPeriod prop in FlatList controls the delay, measured in milliseconds, between batches of cell rendering. It's a crucial parameter for balancing performance and user experience, especially when dealing with large datasets. default is 50. I set it 5.

What changes do you think we should make in order to solve the problem?

    maxToRenderPerBatch={CONST.MAX_TO_RENDER_PER_BATCH.DEFAULT}
    updateCellsBatchingPeriod={CONST.MAX_TO_RENDER_PER_BATCH.DEFAULT}

Added these 2 lines at here.

What alternative solutions did you explore? (Optional)

N/A

Contributor details

Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@puneetlath, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[allgandalf]

Waiting for proposals melv!

[Anaslancer]

@allgandalf Did you have a chance to review my proposal?

[allgandalf]

thanks for the proposal @Anaslancer , can you elaborate a bit on the RCA please :)

[Anaslancer]

Proposal

Updated
@allgandalf I just updated RCA. Thanks

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@puneetlath @allgandalf this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[allgandalf]

@Anaslancer can you point out to links/ SO discussions or anything you have to back your claim?

[Anaslancer]

https://reactnative.dev/docs/optimizing-flatlist-configuration

[melvin-bot]

@puneetlath, @allgandalf Huh... This is 4 days overdue. Who can take care of this?

[allgandalf]

not overdue, waiting for proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Anaslancer]

@allgandalf My proposal not good?

[allgandalf]

can you attach videos reproducing the bug and another video with your solution implemented which resolves the bug @Anaslancer

[Anaslancer]

@allgandalf This video is captured with the original code.

public-room-before.mp4

PS: for reproducing, please use the browser that didn't use recently with new gmail account.

[Anaslancer]

This video is captured with the changed code.

public-room-after.mp4

PS: same, please use the other browser that didn't use recently with new test gmail.

[wildan-m]

Unable to reproduce the issue. Could the tester try testing on a Mac? It might be a bug specific to Chrome on Windows.

[allgandalf]

@lanitochka17 can the tester test on mac env ?

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[puneetlath]

Given that @mvtglobally is saying this isn't reproducible, I'm going to close it out. Feel free to comment or reopen if you think I'm mistaken in doing so.