Expense - Track expense button displayed instead of Submit when creating expense in self DM

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.49.0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #50239
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify/
   and log in
2. Enable combinedTrackSubmit beta
3. Navigate to Self DM
4. Click on + > Create expense > Manual
5. Enter the amount and proceed to the next screen

Expected Result:

The "Submit" button is displayed on the confirmation screen

Actual Result:

The "Track expense" button displayed on the confirmation screen

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6635437_1729008557873.Recording__865.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[cead22]

I get the same on staging and on production, so I don't think we should block on this

[cead22]

@grgia do you know what the behavior is supposed to be here? cc @trjExpensify

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-10-15 18:57:35 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Track expense" button displayed on the confirmation screen

What is the root cause of that problem?

In here, we are display button text is translate('iou.trackExpense') for all cases

App/src/components/MoneyRequestConfirmationList.tsx

Line 440 in 4f1224c

text = translate('iou.trackExpense');

What changes do you think we should make in order to solve the problem?

We should display translate('iou.submitExpense') when canUseCombinedTrackSubmit = true

 const {canUseCombinedTrackSubmit} = usePermissions();

else if (isTypeTrackExpense) {
     text = canUseCombinedTrackSubmit ? translate('iou.submitExpense') : translate('iou.trackExpense');
}

Or we can use translate('iou.createExpense') like we did with other places

What alternative solutions did you explore? (Optional)

[mananjadhav]

Edited by proposal-police: This proposal was edited at 2024-10-15 19:03:42 UTC.

yeah doesn't look like a deploy blocker. We can wait for the confirmation on the behavior but I checked the code.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In the Self DM, when we choose "Create Expense", we always end up with the "Track expense" flow. Check the URL:
/create/track/start/1/{reportId}/manual

What is the root cause of that problem?

In AttachmentPickerWithMenuItems we're updating the text text: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'), based on the canUseCombinedTrackSubmit. The button is still track expense and hence the track flow is triggered.

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 162 to 166 in e8a8c53

	[CONST.IOU.TYPE.TRACK]: {
	icon: canUseCombinedTrackSubmit ? getIconForAction(CONST.IOU.TYPE.CREATE) : getIconForAction(CONST.IOU.TYPE.TRACK),
	text: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),
	onSelected: () => selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK, report?.reportID ?? '-1'), true),
	},

What changes do you think we should make in order to solve the problem?

In the ReportUtils.ts we should add the check for the permissions when we check for isSelfDM.

if (isSelfDM(report)) {
    if (canUseCombinedTrackSubmit) {
        options = [CONST.IOU.TYPE.SUBMIT];
    } else {
        options = [CONST.IOU.TYPE.TRACK];
    } 
}

App/src/libs/ReportUtils.ts

Lines 6784 to 6786 in e8a8c53

	if (isSelfDM(report)) {
	options = [CONST.IOU.TYPE.TRACK];
	}

What alternative solutions did you explore? (Optional)

[paultsimura]

It's always been "Track" as you cannot submit an expense to yourself, only track it. IIRC, the self-dm was where we first implemented the "Track expense" functionality: #36362

Even the chat header says "Use + button to track an expense":

Therefore, this button title looks like expected behavior to me.

[cead22]

Thanks @paultsimura. Closing for now