[$250] [HOLD for payment 2024-11-18] [Per Diem] Frontend - Enabling/Disabling Per Diem in Newdot

[Gonals]

Part of the Add Per Diem to New Expensify project

Main issue: https://github.com/Expensify/Expensify/issues/400276
Doc section: https://docs.google.com/document/d/1c6WDOJlhvODD0mRKaCHfQk_HRNmq5K7hSDHLu06Pbq8/edit?tab=t.0#bookmark=id.yzkaku4zx0eq
Project: https://github.com/Expensify/Expensify/issues/400276

Feature Description

Add the necessary changes to enable/disable Per Diem in newdot workspaces

Manual Test Steps

Automated Tests

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021856534335985560931
• Upwork Job ID: 1856534335985560931
• Last Price Increase: 2024-11-13
• Automatic offers:
• shubham1206agra | Reviewer | 104872133
• c3024 | Contributor | 104872134

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[melvin-bot]

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[Gonals]

@shubham1206agra will be taking point on this issue, as he wrote the section of the design

[shubham1206agra]

@Expensify/design Can I get all the illustration's SVG files?

[dubielzyk-expensify]

I think we should actually just reuse the Lottie animation we already have on the Search page for Tags and Categories:

Potentially we could use the pink background color as described in the mocks. Or not sure if the design was meant to get a new illustration/animation. I'll let @Expensify/design chime in

[shawnborton]

Exactly, I think we can just reuse the existing pattern we have elsewhere as Jon mentions.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Enable/disable per diem rates #51232

If no regressions arise, payment will be issued on 2024-11-18. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)

[jliexpensify]

@Gonals sorry - just checking if this is correct for the other 2 Contributors?

[Gonals]

Yep, that seems accurate, as they reviewed the PRs

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021856534335985560931

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[jliexpensify]

Great, so here's a Pament Summary:

• @s77rt $250 (request in New.Dot)
• @c3024 $250 (paid via Upworks)

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jliexpensify]

No checklist right @shubham1206agra ?

[shubham1206agra]

No checklist

[JmillsExpensify]

$250 approved for @s77rt

[jliexpensify]

Paid and job closed in Upworks!