Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-29] [GR Phase 2] Step 4 Beneficial owner screen (without API calls) #50900

Closed
madmax330 opened this issue Oct 16, 2024 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@madmax330
Copy link
Contributor

Design doc section: https://docs.google.com/document/d/1Y4P7G9h0Easjcea7wyk52gKrNB9o1yTjpmJFYkrHDW4/edit?tab=t.0#bookmark=id.5pc093vnuj1r

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Nov 6, 2024

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

@MrMuzyk MrMuzyk mentioned this issue Nov 12, 2024
49 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Nov 12, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 22, 2024
@melvin-bot melvin-bot bot changed the title [GR Phase 2] Step 4 Beneficial owner screen (without API calls) [HOLD for payment 2024-11-29] [GR Phase 2] Step 4 Beneficial owner screen (without API calls) Nov 22, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 22, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 22, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

  • @hungvu193 requires payment through NewDot Manual Requests
  • @MrMuzyk does not require payment (Contractor)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 29, 2024
Copy link

melvin-bot bot commented Nov 29, 2024

Issue is ready for payment but no BZ is assigned. @sonialiap you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Nov 29, 2024

Payment Summary

Upwork Job

  • Reviewer: @hungvu193 owed $250 via NewDot
  • Contributor: @MrMuzyk is from an agency-contributor and not due payment

BugZero Checklist (@sonialiap)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@sonialiap
Copy link
Contributor

@hungvu193 do we need to add regression steps for this change?

Payment summary:

  • @hungvu193 owed $250 via NewDot
  • @MrMuzyk is from an agency-contributor and not due payment

@hungvu193
Copy link
Contributor

@hungvu193 do we need to add regression steps for this change?

This is new feature, also it's not widely available to all the users (only available with debug mode), so I don't think we need regression test for this issue

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
@madmax330
Copy link
Contributor Author

Waiting for payment

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@sonialiap
Copy link
Contributor

Thanks, since no regression test is needed, closing ✔️

@garrettmknight
Copy link
Contributor

$250 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants