-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS/Android - Hybrid app - "Submit it to someone" option is still shown after tracking expense #50920
Comments
Triggered auto assignment to @jliexpensify ( |
We think that this bug might be related to #wave-collect - Release 1 |
@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
@IuliiaHerets I can repro this but .49-2 was deployed only 7 hrs ago: I'm only on .48 for Hybrid, so can you retest in a few days with the new version? |
Ok I'm on v50 and can still repro. @MariaHCD @abdulrahuman5196 adding you here as you worked on the PR. |
Hmm, weird. The HybridApp version is always be in-sync with App version so it's weird that the issue is fixed on ND but not on HybridApp. Just to double check - @jliexpensify were you testing with an account that is not on the P2P beta? |
Hmm are our standard expensify accounts on the beta? That's what I tested on. |
So just to confirm...this is still an issue/bug right? |
It's not a bug if the account is on the P2P distance requests beta. If this is happening on accounts that are not on the beta, then it would be a bug. Can we retest on an account that is not on the beta? |
Thanks for clariofying @MariaHCD - I tested on a personal account on Hybrid and it's all good: Closing this then! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was found when executing this PR: #50331
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The actionable whisper of the expense created in (2) has no
Submit it to someone
option/button (unless you enable P2P Beta)Actual Result:
Submit to someone
option is still shownWorkaround:
Unknown
Platforms:
Screenshots/Videos
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: