Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS/Android - Hybrid app - "Submit it to someone" option is still shown after tracking expense #50920

Closed
2 of 8 tasks
IuliiaHerets opened this issue Oct 16, 2024 · 11 comments
Closed
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was found when executing this PR: #50331
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the Expenisfy Hybrid app
  2. Sign into a valid account and access the ND features within the app
  3. Go to self DM.
  4. Click + > Track expense > Distance > Complete the flow

Expected Result:

The actionable whisper of the expense created in (2) has no Submit it to someone option/button (unless you enable P2P Beta)

Actual Result:

Submit to someone option is still shown

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screenshot_20241016-184557

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 16, 2024
Copy link

melvin-bot bot commented Oct 16, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@IuliiaHerets
Copy link
Author

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@jliexpensify
Copy link
Contributor

@IuliiaHerets I can repro this but .49-2 was deployed only 7 hrs ago:

image

I'm only on .48 for Hybrid, so can you retest in a few days with the new version?

@jliexpensify jliexpensify added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Oct 17, 2024
@muttmuure muttmuure moved this to MEDIUM in [#whatsnext] #quality Oct 17, 2024
@jliexpensify
Copy link
Contributor

Ok I'm on v50 and can still repro.

@MariaHCD @abdulrahuman5196 adding you here as you worked on the PR.

@jliexpensify jliexpensify removed the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Oct 18, 2024
@MariaHCD
Copy link
Contributor

Hmm, weird. The HybridApp version is always be in-sync with App version so it's weird that the issue is fixed on ND but not on HybridApp.

Just to double check - @jliexpensify were you testing with an account that is not on the P2P beta?

@jliexpensify
Copy link
Contributor

Hmm are our standard expensify accounts on the beta? That's what I tested on.

@MariaHCD
Copy link
Contributor

Ah, yes, expensify accounts are on the P2P Distance Requests beta:

Screenshot 2024-10-18 at 12 06 25 PM

@jliexpensify
Copy link
Contributor

So just to confirm...this is still an issue/bug right?

@MariaHCD
Copy link
Contributor

It's not a bug if the account is on the P2P distance requests beta. If this is happening on accounts that are not on the beta, then it would be a bug.

Can we retest on an account that is not on the beta?

@jliexpensify
Copy link
Contributor

Thanks for clariofying @MariaHCD - I tested on a personal account on Hybrid and it's all good:

Screenshot_20241021-183653

Closing this then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Development

No branches or pull requests

4 participants