[HOLD for payment 2024-11-21] [$250] Inbox showing GBR when there’s a report with RBR #50927

m-natarajan · 2024-10-16T17:27:14Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.49-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @pac-guerreiro
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1728665408536049

Action Performed:

Make sure there is at least a report with GBR and another with a RBR
Select a report which hasn’t a RBR indicator
Go to Troubleshoot, then click on Clear cache and restart
Go back to Inbox and check that the Inbox is showing a GBR indicator
Open the report that has the RBR indicator then refresh the page

Expected Result:

Should have same logic that should display RBR in inbox

Actual Result:

The inbox indicator doesn’t show an updated color until the page is refreshed and it shows the wrong color until a report is fully loaded

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Recording.665.mp4

Screen.Recording.2024-10-16.at.15.48.24.mov

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021847128366508796109
Upwork Job ID: 1847128366508796109
Last Price Increase: 2024-10-18
Automatic offers:

mkhutornyi | Reviewer | 104590221
truph01 | Contributor | 104590223

Issue Owner

Current Issue Owner: @alexpensify

melvin-bot · 2024-10-16T17:27:23Z

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

FitseTLT · 2024-10-16T21:25:04Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inbox showing GBR when there’s a report with RBR

What is the root cause of that problem?

We are only recalculating chat tab rbr value for transactionViolation and activeWorkspaceID changes here

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 72 to 73 in 4a25c36

    
               setChatTabBrickRoad(getChatTabBrickRoad(activeWorkspaceID)); 
        
           }, [activeWorkspaceID, transactionViolations]);

But inside getChatTabBrickRoad we use the status of allReports to calculate the value of rbr. But, allReports will not be available immediately after a user clears caches/onyx data so the rbr value will be calculated without the list of reports which will result wrong value and there is no recalculation held when the reports are loaded in onyx so it will remain green until we reload the page

What changes do you think we should make in order to solve the problem?

We should subscribe to reports collection and use it in the calculation of rbr value

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 69 to 73 in 4a25c36

    
           const [chatTabBrickRoad, setChatTabBrickRoad] = useState<BrickRoad>(getChatTabBrickRoad(activeWorkspaceID)); 
        
           useEffect(() => { 
        
               setChatTabBrickRoad(getChatTabBrickRoad(activeWorkspaceID)); 
        
           }, [activeWorkspaceID, transactionViolations]);

App/src/libs/Navigation/AppNavigator/createCustomPlatformStackBottomTabNavigator/BottomTabBar.tsx

Lines 76 to 79 in 4a25c36

    
           const [chatTabBrickRoad, setChatTabBrickRoad] = useState<BrickRoad>(getChatTabBrickRoad(activeWorkspaceID)); 
        
           useEffect(() => { 
        
               setChatTabBrickRoad(getChatTabBrickRoad(activeWorkspaceID));

    const [allReports] = useOnyx(ONYXKEYS.COLLECTION.REPORT);
    const [chatTabBrickRoad, setChatTabBrickRoad] = useState<BrickRoad>(getChatTabBrickRoad(activeWorkspaceID, allReports));

    useEffect(() => {
        setChatTabBrickRoad(getChatTabBrickRoad(activeWorkspaceID,allReports));
    }, [activeWorkspaceID, transactionViolations,allReports]);

App/src/libs/WorkspacesSettingsUtils.ts

Lines 122 to 123 in 4a25c36

    
           function getChatTabBrickRoad(policyID?: string): BrickRoad | undefined { 
        
               const allReports = ReportConnection.getAllReports();

function getChatTabBrickRoad(policyID?: string, allReportsParam): BrickRoad | undefined {
    const allReports = allReportsParam ?? ReportConnection.getAllReports();

It's not a must to use the useOnyx allreports data in getChatTabBrickRoad to fix the issue; only adding allReports to useEffect's dependency suffices, but I think it is generally accepted approach to use it

What alternative solutions did you explore? (Optional)

pac-guerreiro · 2024-10-17T07:25:14Z

I just want to clarify that there are two problems here:

Inbox indicator is not updated in realtime
Inbox indicator is green when there are reports with RBR until at least one RBR is opened manually by the user

To replicate the issue you can also do a fresh login instead of clearing onyx cache.

I had to fix the 1st problem on one of my debug mode PRs for it to work properly but the PR hasn't been merged yet (link to the fix).

If you agree, this bug could be just focused on the 2nd problem. Otherwise I'll discard the fix I did on my PR.

truph01 · 2024-10-17T09:42:18Z

Edited by proposal-police: This proposal was edited at 2024-10-17 09:47:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inbox has no GBR or RBR indicator until the page is refreshed

What is the root cause of that problem?

Currently, in the logic to get the RBR for policy, we do not consider the transaction violation and report violations as we did when display RBR in LHN:

App/src/libs/WorkspacesSettingsUtils.ts

Lines 66 to 78 in 77a37a1

    
           if (oneTransactionThreadReportID) { 
        
               const oneTransactionThreadReport = ReportUtils.getReport(oneTransactionThreadReportID); 
        
               if ( 
        
                   ReportUtils.shouldDisplayTransactionThreadViolations( 
        
                       oneTransactionThreadReport, 
        
                       allTransactionViolations, 
        
                       reportActions[oneTransactionThreadReport?.parentReportActionID ?? '-1'], 
        
                   ) 
        
               ) { 
        
                   doesReportContainErrors = CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR; 
        
               } 
        
           }

What changes do you think we should make in order to solve the problem?

We should add the logic to cover the violations in:

App/src/libs/WorkspacesSettingsUtils.ts

Line 64 in 77a37a1

let doesReportContainErrors = Object.keys(reportErrors ?? {}).length !== 0 ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined;

    const parentReportActions = (altReportActions ?? allReportActions)?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report?.parentReportID}`];
    const parentReportAction = parentReportActions?.[report?.parentReportActionID ?? '-1'];
    const shouldDisplayViolations = ReportUtils.shouldDisplayTransactionThreadViolations(report, allTransactionViolations, parentReportAction);
    const shouldDisplayReportViolations = ReportUtils.isReportOwner(report) && ReportUtils.hasReportViolations(report.reportID);
    const hasViolations = shouldDisplayViolations || shouldDisplayReportViolations;    
    if (hasViolations) {
        doesReportContainErrors = CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR;
    }

And then update:

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 71 to 73 in bcc6263

    
           useEffect(() => { 
        
               setChatTabBrickRoad(getChatTabBrickRoad(activeWorkspaceID)); 
        
           }, [activeWorkspaceID, transactionViolations]);

    const report = useOnyx(ONYXKEYS.COLLECTION.REPORT);
    const reportActions = useOnyx(ONYXKEYS.COLLECTION.REPORT_ACTIONS);
    const [chatTabBrickRoad, setChatTabBrickRoad] = useState<BrickRoad>(getChatTabBrickRoad(activeWorkspaceID));

    useEffect(() => {
        setChatTabBrickRoad(getChatTabBrickRoad(activeWorkspaceID));
    }, [activeWorkspaceID, transactionViolations, report, reportActions]);

to make sure the reports, reportActions data are updated immediately.

What alternative solutions did you explore? (Optional)

melvin-bot · 2024-10-18T04:11:37Z

Job added to Upwork: https://www.upwork.com/jobs/~021847128366508796109

melvin-bot · 2024-10-18T04:11:41Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

alexpensify · 2024-10-18T04:12:39Z

@mkhutornyi - can you please identify if one of these proposals will fix this issue? Thanks!

Heads up, I will be offline until Tuesday, October 22, 2024, and will not actively watch over this GitHub during that period.

If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.

FitseTLT · 2024-10-18T17:46:42Z

The issue is very similar to #50364

truph01 · 2024-10-18T22:56:12Z

As mentioned by @pac-guerreiro, this bug is to fix:

Inbox indicator is green when there are reports with RBR until at least one RBR is opened manually by the user

melvin-bot · 2024-10-21T18:39:56Z

@alexpensify, @mkhutornyi Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

mkhutornyi · 2024-10-21T18:40:47Z

reviewing 2 proposals

mkhutornyi · 2024-10-22T20:10:47Z

Inbox indicator is not updated in realtime

This was already fixed in #49962

Inbox indicator is green when there are reports with RBR until at least one RBR is opened manually by the user

This is bug to fix here.

@truph01 can you please explain why the bug is gone after at least one RBR is opened manually in RCA?

truph01 · 2024-10-22T20:50:45Z

can you please explain why the bug is gone after at least one RBR is opened manually in RCA?

As you can see, we are only considering the case the report is one transaction report:

App/src/libs/WorkspacesSettingsUtils.ts

Lines 66 to 78 in 77a37a1

    
           if (oneTransactionThreadReportID) { 
        
               const oneTransactionThreadReport = ReportUtils.getReport(oneTransactionThreadReportID); 
        
               if ( 
        
                   ReportUtils.shouldDisplayTransactionThreadViolations( 
        
                       oneTransactionThreadReport, 
        
                       allTransactionViolations, 
        
                       reportActions[oneTransactionThreadReport?.parentReportActionID ?? '-1'], 
        
                   ) 
        
               ) { 
        
                   doesReportContainErrors = CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR; 
        
               } 
        
           }

And because the one transaction report data can only be available after we call OpenReport for the expense report, so the bug is gone after at least one RBR is opened.

mkhutornyi · 2024-10-22T20:53:47Z

And because the one transaction report data can only be available after we call OpenReport for the expense report, so the bug is gone after at least one RBR is opened.

@truph01 I am confused. Are you saying that this bug happens only when one transaction report has RBR?

truph01 · 2024-10-22T20:57:56Z

Are you saying that this bug happens only when one transaction report has RBR

No, that's not what I meant. To clarify, the bug occurs in both cases—whether it's a single transaction report or not. However, when it's a single transaction report, the bug disappears after visiting the expense report page, which is what we are discussing.

mkhutornyi · 2024-10-22T21:00:02Z

ok so if it's not a single transaction report, bug won't disappear even after refresh?

truph01 · 2024-10-22T21:02:37Z

ok so if it's not a single transaction report, bug won't disappear even after refresh?

Yes. If it's not a single transaction report, bug won't disappear even after refresh or visit any RBR report.

mkhutornyi · 2024-10-23T06:02:46Z

@truph01's proposal looks good to me.
🎀👀🎀 C+ reviewed

melvin-bot · 2024-10-23T06:02:59Z

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2024-10-25T14:21:20Z

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-10-25T14:21:24Z

📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

alexpensify · 2024-10-28T15:44:42Z

@truph01 - any update for the PR here? Thanks!

melvin-bot · 2024-10-28T18:29:51Z

@tgolen, @alexpensify, @mkhutornyi, @truph01 Whoops! This issue is 2 days overdue. Let's get this updated quick!

alexpensify · 2024-11-07T21:46:45Z

Update: PR is in review!

melvin-bot · 2024-11-14T00:41:58Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-11-14T00:42:03Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Inbox showing GBR when there’s a report with RBR #51643

If no regressions arise, payment will be issued on 2024-11-21. 🎊

For reference, here are some details about the assignees on this issue:

@mkhutornyi requires payment automatic offer (Reviewer)
@truph01 requires payment automatic offer (Contributor)
@pac-guerreiro does not require payment (Contractor)

melvin-bot · 2024-11-14T00:42:04Z

@tgolen @alexpensify @mkhutornyi / @truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

alexpensify · 2024-11-22T01:22:59Z

Payouts due: 2024-11-21

Contributor: $250 @truph01
Reviewer: $250 @mkhutornyi

Upwork job is here.

alexpensify · 2024-11-22T01:26:50Z

Everyone has been paid via Upwork. @mkhutornyi - can you please complete the checklist and confirm if there is a regression test? Thanks!

melvin-bot · 2024-11-25T09:12:41Z

@tgolen, @alexpensify, @mkhutornyi, @truph01 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

alexpensify · 2024-11-25T19:53:15Z

Closing

m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 16, 2024

melvin-bot bot assigned alexpensify Oct 16, 2024

alexpensify added this to [#whatsnext] #quality Oct 18, 2024

alexpensify added the External Added to denote the issue can be worked on by a contributor label Oct 18, 2024

melvin-bot bot changed the title ~~Inbox showing GBR when there’s a report with RBR~~ [$250] Inbox showing GBR when there’s a report with RBR Oct 18, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 18, 2024

melvin-bot bot assigned mkhutornyi Oct 18, 2024

muttmuure moved this to MEDIUM in [#whatsnext] #quality Oct 18, 2024

melvin-bot bot added the Overdue label Oct 21, 2024

melvin-bot bot removed the Overdue label Oct 21, 2024

melvin-bot bot added the Overdue label Oct 25, 2024

muttmuure moved this from MEDIUM to CRITICAL in [#whatsnext] #quality Oct 28, 2024

truph01 mentioned this issue Oct 29, 2024

fix: Inbox showing GBR when there’s a report with RBR #51643

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Oct 29, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 14, 2024

melvin-bot bot changed the title ~~[$250] Inbox showing GBR when there’s a report with RBR~~ [HOLD for payment 2024-11-21] [$250] Inbox showing GBR when there’s a report with RBR Nov 14, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Nov 14, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 20, 2024

melvin-bot bot added the Overdue label Nov 25, 2024

alexpensify closed this as completed Nov 25, 2024

melvin-bot bot removed the Overdue label Nov 25, 2024

github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Nov 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-11-21] [$250] Inbox showing GBR when there’s a report with RBR #50927

[HOLD for payment 2024-11-21] [$250] Inbox showing GBR when there’s a report with RBR #50927

m-natarajan commented Oct 16, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Oct 16, 2024

FitseTLT commented Oct 16, 2024

pac-guerreiro commented Oct 17, 2024 •

edited

Loading

truph01 commented Oct 17, 2024 •

edited by github-actions bot

Loading

melvin-bot bot commented Oct 18, 2024

melvin-bot bot commented Oct 18, 2024

alexpensify commented Oct 18, 2024 •

edited

Loading

FitseTLT commented Oct 18, 2024

truph01 commented Oct 18, 2024

melvin-bot bot commented Oct 21, 2024

mkhutornyi commented Oct 21, 2024

mkhutornyi commented Oct 22, 2024

truph01 commented Oct 22, 2024

mkhutornyi commented Oct 22, 2024

truph01 commented Oct 22, 2024

mkhutornyi commented Oct 22, 2024

truph01 commented Oct 22, 2024

mkhutornyi commented Oct 23, 2024

melvin-bot bot commented Oct 23, 2024

melvin-bot bot commented Oct 25, 2024

melvin-bot bot commented Oct 25, 2024

alexpensify commented Oct 28, 2024

melvin-bot bot commented Oct 28, 2024

alexpensify commented Nov 7, 2024

melvin-bot bot commented Nov 14, 2024

melvin-bot bot commented Nov 14, 2024

melvin-bot bot commented Nov 14, 2024

alexpensify commented Nov 22, 2024 •

edited

Loading

alexpensify commented Nov 22, 2024

melvin-bot bot commented Nov 25, 2024

alexpensify commented Nov 25, 2024

[HOLD for payment 2024-11-21] [$250] Inbox showing GBR when there’s a report with RBR #50927

[HOLD for payment 2024-11-21] [$250] Inbox showing GBR when there’s a report with RBR #50927

Comments

m-natarajan commented Oct 16, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 16, 2024

FitseTLT commented Oct 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

pac-guerreiro commented Oct 17, 2024 • edited Loading

truph01 commented Oct 17, 2024 • edited by github-actions bot Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Oct 18, 2024

melvin-bot bot commented Oct 18, 2024

alexpensify commented Oct 18, 2024 • edited Loading

Heads up, I will be offline until Tuesday, October 22, 2024, and will not actively watch over this GitHub during that period.

FitseTLT commented Oct 18, 2024

truph01 commented Oct 18, 2024

melvin-bot bot commented Oct 21, 2024

mkhutornyi commented Oct 21, 2024

mkhutornyi commented Oct 22, 2024

truph01 commented Oct 22, 2024

mkhutornyi commented Oct 22, 2024

truph01 commented Oct 22, 2024

mkhutornyi commented Oct 22, 2024

truph01 commented Oct 22, 2024

mkhutornyi commented Oct 23, 2024

melvin-bot bot commented Oct 23, 2024

melvin-bot bot commented Oct 25, 2024

melvin-bot bot commented Oct 25, 2024

alexpensify commented Oct 28, 2024

melvin-bot bot commented Oct 28, 2024

alexpensify commented Nov 7, 2024

melvin-bot bot commented Nov 14, 2024

melvin-bot bot commented Nov 14, 2024

melvin-bot bot commented Nov 14, 2024

alexpensify commented Nov 22, 2024 • edited Loading

alexpensify commented Nov 22, 2024

melvin-bot bot commented Nov 25, 2024

alexpensify commented Nov 25, 2024

m-natarajan commented Oct 16, 2024 •

edited by melvin-bot bot

Loading

pac-guerreiro commented Oct 17, 2024 •

edited

Loading

truph01 commented Oct 17, 2024 •

edited by github-actions bot

Loading

alexpensify commented Oct 18, 2024 •

edited

Loading

alexpensify commented Nov 22, 2024 •

edited

Loading