Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-18] [Search v2.5] [Autocomplete] Implement the "in" autocomplete #50943

Closed
lakchote opened this issue Oct 16, 2024 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lakchote
Copy link
Contributor

See https://docs.google.com/document/d/1o-Hp-tK8Z_BAcE-KRiXQicPH04qNr525EIxlG8J4RxM/edit?tab=t.0#bookmark=id.12hnqjn49rnl

@lakchote lakchote moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Oct 16, 2024
@luacmartins luacmartins changed the title [Search] [Autocomplete] Implement the "in" autocomplete [Search v2.5] [Autocomplete] Implement the "in" autocomplete Oct 16, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Oct 16, 2024
@dylanexpensify dylanexpensify moved this from Release 3: Fall 2024 (Nov) to Polish in [#whatsnext] #expense Oct 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
@luacmartins
Copy link
Contributor

We'll start working on it soon.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 21, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

@lakchote, @luacmartins, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

@lakchote
Copy link
Contributor Author

We'll start working on it soon.

Same.

@melvin-bot melvin-bot bot removed the Overdue label Oct 29, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 31, 2024
@luacmartins luacmartins moved this from External Bugs and Follow Up Issues to Done in [#whatsnext] #expense Nov 6, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 11, 2024
@melvin-bot melvin-bot bot changed the title [Search v2.5] [Autocomplete] Implement the "in" autocomplete [HOLD for payment 2024-11-18] [Search v2.5] [Autocomplete] Implement the "in" autocomplete Nov 11, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 11, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-18. 🎊

For reference, here are some details about the assignees on this issue:

@rayane-djouah
Copy link
Contributor

No need for regression test steps for now; they will be added as part of the project wrap-up.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 18, 2024
Copy link

melvin-bot bot commented Nov 18, 2024

Issue is ready for payment but no BZ is assigned. @sonialiap you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Nov 18, 2024

Payment Summary

Upwork Job

BugZero Checklist (@sonialiap)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@sonialiap
Copy link
Contributor

Looks like there were some things that were updated later but there weren't any regressions, is that correct @lakchote @luacmartins? Payment only for rayane-djouah for this PR, correct?

@lakchote
Copy link
Contributor Author

Looks like there were some things that were updated later but there weren't any regressions, is that correct @lakchote @luacmartins? Payment only for rayane-djouah for this PR, correct?

That's correct @sonialiap, payment only for @rayane-djouah in this PR as a C+ reviewer. Minor issues were found but no regressions, they will be solved in a follow up PR by @Kicu.

@sonialiap
Copy link
Contributor

Thanks Lucien!

@sonialiap
Copy link
Contributor

Payment summary:

@sonialiap
Copy link
Contributor

paid ✔️
no regression steps ✔️ #50943 (comment)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants