Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-11-11] [Search v2.5] [Autocomplete] Implement keyboard navigation for suggestions #50948

Closed
lakchote opened this issue Oct 16, 2024 · 5 comments
Closed

[HOLD for payment 2024-11-11] [Search v2.5] [Autocomplete] Implement keyboard navigation for suggestions #50948

lakchote opened this issue Oct 16, 2024 · 5 comments
Assignees
@lakchote @luacmartins
Labels
Engineering Weekly KSv2

Comments

@lakchote
Copy link
Contributor

See https://docs.google.com/document/d/1o-Hp-tK8Z_BAcE-KRiXQicPH04qNr525EIxlG8J4RxM/edit?tab=t.0#bookmark=id.pp1n1c15oy8k
@lakchote lakchote moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Oct 16, 2024
@luacmartins luacmartins changed the title [Search] [Autocomplete] Implement keyboard navigation for suggestions [Search v2.5] [Autocomplete] Implement keyboard navigation for suggestions Oct 16, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Oct 16, 2024
@dylanexpensify dylanexpensify moved this from Release 3: Fall 2024 (Nov) to Polish in [#whatsnext] #expense Oct 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
@luacmartins
Copy link
Contributor

We'll start working on it soon.

@melvin-bot melvin-bot bot removed the Overdue label Oct 21, 2024
@SzymczakJ SzymczakJ mentioned this issue Oct 22, 2024
Merged
49 tasks
@luacmartins
Copy link
Contributor

We're implementing a bunch of these autocomplete issues with a single PR, so I'll remove C+ assigned from all but one issue.

@luacmartins luacmartins added Weekly KSv2 and removed Daily KSv2 labels Oct 22, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 25, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 4, 2024
@melvin-bot melvin-bot bot changed the title [Search v2.5] [Autocomplete] Implement keyboard navigation for suggestions [HOLD for payment 2024-11-11] [Search v2.5] [Autocomplete] Implement keyboard navigation for suggestions Nov 4, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 4, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-11. 🎊

@luacmartins
Copy link
Contributor

Closing in favor of #50942, since payment will be processed there.

@luacmartins luacmartins removed the Awaiting Payment Auto-added when associated PR is deployed to production label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lakchote lakchote

@luacmartins luacmartins

Labels
Engineering Weekly KSv2
Projects
[#whatsnext] #expense
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lakchote @luacmartins @rayane-djouah