[HOLD for payment 2024-11-01] [Search] [Saved Searches] Do not render tooltip more than once

[lakchote]

After having discussed it with @JmillsExpensify, we should not display the saved searches tooltip more than once.

Because:

• once is enough for training purposes
• the three dots pattern is already well-known

Example of what's expected:

1. I save a search for the first time
2. I delete it
3. I resave another search
4. I should not see the tooltip displayed again

Issue Owner

Current Issue Owner: @JmillsExpensify

[luacmartins]

@lakchote can we instead of deleting the saved search nvp in the DB just set it to an empty object? that way we can cehck for the presence of the nvp

[lakchote]

@lakchote can we instead of deleting the saved search nvp in the DB just set it to an empty object? that way we can cehck for the presence of the nvp

Good idea. That's what I've done, PRs are in review for both the backend and frontend.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Search] [Saved Searches] Do not render tooltip more than once #51076

If no regressions arise, payment will be issued on 2024-11-01. 🎊

[JmillsExpensify]

Doesn't look like any payment is due, so I'm going to close this one out.

[mananjadhav]

@JmillsExpensify I had helped with the PR review on this one. Can you please help with the payout summary on this one?

[JmillsExpensify]

Ah thanks, I see that in the PRs so thanks for raising.

[JmillsExpensify]

Payment summary: $250 to @mananjadhav for PR testing and review.

[garrettmknight]

$250 approved for @mananjadhav