-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for #49355][$250] Room - HTML text is shown in Room Description #51048
Comments
Triggered auto assignment to @kadiealexander ( |
@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.The room description is currently displayed as an object, rather than plain text. What is the root cause of that problem?This issue occurs because the room description is being handled as a JSON object, but we are not properly parsing it or accessing the html property inside the objec What changes do you think we should make in order to solve the problem?To resolve the issue, we need to parse the JSON object and extract the html property before processing the description as: Line 4242 in 2c00cc5
as: Line 571 in 2c00cc5
|
ProposalPlease re-state the problem that we are trying to solve in this issue.HTML text is shown in Room Description What is the root cause of that problem?This problem is caused by a change in the backend data type, specifically at the What changes do you think we should make in order to solve the problem?To fix this issue, we have two options. The first option is to update the backend so that the //.src/libs/actions/Report.ts#L548
const successData: OnyxUpdate[] = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`,
value: successReportActions,
},
+ {
+ onyxMethod: Onyx.METHOD.MERGE,
+ key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
+ value: {
+ description: report?.description,
+ },
+ },
+ ];
Screen.Recording.2024-10-18.at.03.38.03.mov |
Job added to Upwork: https://www.upwork.com/jobs/~021847054312559267621 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach ( |
Dupe #49355 |
@kadiealexander, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Hmmmm @kadiealexander |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Issue not reproducible during KI retests. (First week) |
Confirm ! @kadiealexander |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
User expects the description to be unaffected
Actual Result:
HTML text is displayed after sending a message (OR leaving and joining the room via message)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6638033_1729189658092.HTML_shown_after_leaving_and_joining_room_via_message.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ZhenjaHorbachThe text was updated successfully, but these errors were encountered: