-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-11-11] Appover's details are shown when hovering on submitter's name on report preview #51050
Comments
Triggered auto assignment to @greg-schroeder ( |
Edited by proposal-police: This proposal was edited at 2024-10-17 19:39:33 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.The approver's details are displayed when hovering over the submitter's name in the report preview. What is the root cause of that problem?In this PR , we added a special case for However, when hovering over this display name, it shows the approver's information because, in the ReportActionItemFragment , we are passing This is problematic because What changes do you think we should make in order to solve the problem?We can modify this line so that accountID={(isReportPreviewAction && ReportUtils.isPolicyExpenseChat(report) ? ownerAccountID : actorAccountID) ?? -1} we should also change
What alternative solutions did you explore? (Optional)Another approach is to use accountID={avatarId ?? -1} additionally if we want to fix the navigation issue that was mention in this proposal, we should also change |
ProposalPlease re-state the problem that we are trying to solve in this issue.Appover's details are shown when hovering on submitter's name on report preview What is the root cause of that problem?We have 2 problems here Screen.Recording.2024-10-18.at.1.23.49.AM.movHere we are passing
which uses
but here we pass
What changes do you think we should make in order to solve the problem?For 1's problem we can fix it by passing
We can do something like this
To fix incorrect navigation here we can also pass
Optional: Here we already set
We should also check for other places too where we can use What alternative solutions did you explore? (Optional) |
Proposal updatedupdated proposal to fix navigation consistency pointed by the other proposal. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Was this fixed? Im not able to reproduce |
Looking now |
PR is in review |
Georgia is still working on requested changes! |
This is on staging. Awaiting deploy to prod |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-11. 🎊 |
@grgia @greg-schroeder The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
$250 approved for @s77rt |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.50-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @cead22
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729182103612369
Action Performed:
Expected Result:
Submitter's details are shown
Actual Result:
Approver's name and email, and my avatar. It also shows his status emoji and message
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
![image (10)](https://github.com/user-attachments/assets/0c5fba02-95cf-43ba-bbf8-f5fd8393750e) ![image (9)](https://github.com/user-attachments/assets/49a685dc-67f0-479e-a79a-a0d8619f74af) ![image (8)](https://github.com/user-attachments/assets/80564152-0438-438a-9c2d-a5657126ba4b)Recording.667.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @greg-schroederThe text was updated successfully, but these errors were encountered: