Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Waiting on Checklist] [$125] [Dev] Console Warning: No native ExponentConstants module found #51054

Closed
1 of 8 tasks
m-natarajan opened this issue Oct 17, 2024 · 26 comments
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@m-natarajan
Copy link

m-natarajan commented Oct 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: DEV
Reproducible in production?: DEV
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @eVoloshchak
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729174865370699

Action Performed:

  1. Launch the iOS app
  2. Observe the warning

Expected Result:

No warning is displayed

Actual Result:

Warning is displayed

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence ![Simulator Screenshot - iPhone 15 Pro - 2024-10-17 at 16 17 56](https://github.com/user-attachments/assets/2e076611-8c45-408f-ac83-fa1e228efc92)
Screen.Recording.2024-10-17.at.16.20.46.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021849240595196131510
  • Upwork Job ID: 1849240595196131510
  • Last Price Increase: 2024-10-24
Issue OwnerCurrent Issue Owner: @twisterdotcom
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@bernhardoj
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

A "No native ExponentConstants module found" warning is shown.

What is the root cause of that problem?

We don't link the expo-const module, so it's not found.

App/package.json

Lines 354 to 357 in c3d33fc

"expo": {
"autolinking": {
"exclude": [
"expo-constants",

expo-const is being used in expo-asset module and it's found in PlatformUtils file. However, all the properties that is being used inside the file doesn't exist even if we installed the expo-const.
https://github.com/expo/expo/blob/d576550145ede25dec3f6636bf260f7b05bec7a6/packages/expo-asset/src/PlatformUtils.ts#L32-L39

So, it's no different whether we include expo-const module or not. Here is the available properites from expo-const.

{"addListener": [Function addListener], "debugMode": true, "deviceName": "iPhone 15 Plus", "emit": [Function emit], "executionEnvironment": "bare", "getWebViewUserAgentAsync": [Function getWebViewUserAgentAsync], "isHeadless": false, "listenerCount": [Function listenerCount], "manifest": {"description": "New Expensify is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.", "name": "new.expensify", "platforms": ["ios", "android", "web"], "sdkVersion": "51.0.0", "slug": "new.expensify", "version": "9.0.50-7"}, "platform": {"ios": {"buildNumber": "9.0.50.7"}}, "removeAllListeners": [Function removeAllListeners], "removeListener": [Function removeListener], "removeSubscription": [Function removeSubscription], "sessionId": "715902EE-F726-43EA-B204-6797A7E27318", "statusBarHeight": 54, "systemFonts": [listOfFontsTooLong]}

What changes do you think we should make in order to solve the problem?

We can suppress the warning. One way to do it is by suppressing it here.

App/src/App.tsx

Lines 48 to 53 in c3d33fc

LogBox.ignoreLogs([
// Basically it means that if the app goes in the background and back to foreground on Android,
// the timer is lost. Currently Expensify is using a 30 minutes interval to refresh personal details.
// More details here: https://git.io/JJYeb
'Setting a timer for a long period of time',
]);

'No native ExponentConstants module found',

OR

We can link the expo-const by remove it from the auto-link exclude list.

App/package.json

Lines 354 to 357 in c3d33fc

"expo": {
"autolinking": {
"exclude": [
"expo-constants",

@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Oct 23, 2024

@twisterdotcom Huh... This is 4 days overdue. Who can take care of this?

@twisterdotcom
Copy link
Contributor

Seems straightforward right? I haven't recreated this, so will lean on C+ too for this dev specific issue.

@melvin-bot melvin-bot bot removed the Overdue label Oct 24, 2024
@twisterdotcom twisterdotcom added the External Added to denote the issue can be worked on by a contributor label Oct 24, 2024
@melvin-bot melvin-bot bot changed the title [Dev] Console Warning: No native ExponentConstants module found [$250] [Dev] Console Warning: No native ExponentConstants module found Oct 24, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021849240595196131510

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 24, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@twisterdotcom twisterdotcom changed the title [$250] [Dev] Console Warning: No native ExponentConstants module found [$125] [Dev] Console Warning: No native ExponentConstants module found Oct 24, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

Upwork job price has been updated to $125

@twisterdotcom
Copy link
Contributor

Downgrading as this isn't customer facing.

@twisterdotcom twisterdotcom added Weekly KSv2 and removed Daily KSv2 labels Oct 24, 2024
@mollfpr
Copy link
Contributor

mollfpr commented Oct 28, 2024

I'm assuming we exclude the expo-constants to reduce the binary size. I think we can suppress the warning like it proposed from @bernhardoj.

🎀 👀 🎀 C+ reviewed!

Copy link

melvin-bot bot commented Oct 28, 2024

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@blimpich
Copy link
Contributor

Proposal seems good, but question: why is this only getting reported and fixed now? The PR that added that code was merged 10 months ago. Did we just live with warning until @eVoloshchak decided to report it?

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 28, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 29, 2024
@bernhardoj
Copy link
Contributor

PR is ready
cc: @mollfpr

Did we just live with warning until @eVoloshchak decided to report it?

I think yes. There has been so much warning on the app that I think people keep ignoring them 😅

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 6, 2024
@melvin-bot melvin-bot bot changed the title [$125] [Dev] Console Warning: No native ExponentConstants module found [HOLD for payment 2024-11-13] [$125] [Dev] Console Warning: No native ExponentConstants module found Nov 6, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 6, 2024
Copy link

melvin-bot bot commented Nov 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

  • @mollfpr requires payment through NewDot Manual Requests
  • @bernhardoj requires payment through NewDot Manual Requests
  • @eVoloshchak requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Nov 6, 2024

@mollfpr @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 12, 2024
Copy link

melvin-bot bot commented Nov 13, 2024

Payment Summary

Upwork Job

BugZero Checklist (@twisterdotcom)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1849240595196131510/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@bernhardoj
Copy link
Contributor

Requested in ND.

@twisterdotcom twisterdotcom removed the Awaiting Payment Auto-added when associated PR is deployed to production label Nov 13, 2024
@twisterdotcom twisterdotcom changed the title [HOLD for payment 2024-11-13] [$125] [Dev] Console Warning: No native ExponentConstants module found [Waiting on Checklist] [$125] [Dev] Console Warning: No native ExponentConstants module found Nov 13, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

@twisterdotcom @blimpich @mollfpr @bernhardoj this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot added the Overdue label Nov 14, 2024
@twisterdotcom twisterdotcom removed the Needs Reproduction Reproducible steps needed label Nov 14, 2024
@twisterdotcom
Copy link
Contributor

It is done Melv. Just waiting on @mollfpr to do the checklist, although... looking again, I don't think we need one just for this console error. Going to close.

@JmillsExpensify
Copy link

JmillsExpensify commented Nov 14, 2024

$125 approved for @bernhardoj

@JmillsExpensify
Copy link

Actually wait, going to confirm the amounts with @twisterdotcom via DM.

@JmillsExpensify
Copy link

Payment summary is updated and so is my approval amount.

@mollfpr
Copy link
Contributor

mollfpr commented Nov 14, 2024

Sorry for the delay! Yes, we don't need the checklist here.

@garrettmknight
Copy link
Contributor

$125 approved for @mollfpr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

8 participants