-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Waiting on Checklist] [$125] [Dev] Console Warning: No native ExponentConstants module found #51054
Comments
Triggered auto assignment to @twisterdotcom ( |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
ProposalPlease re-state the problem that we are trying to solve in this issue.A "No native ExponentConstants module found" warning is shown. What is the root cause of that problem?We don't link the expo-const module, so it's not found. Lines 354 to 357 in c3d33fc
expo-const is being used in expo-asset module and it's found in PlatformUtils file. However, all the properties that is being used inside the file doesn't exist even if we installed the expo-const. So, it's no different whether we include expo-const module or not. Here is the available properites from expo-const.
What changes do you think we should make in order to solve the problem?We can suppress the warning. One way to do it is by suppressing it here. Lines 48 to 53 in c3d33fc
OR We can link the expo-const by remove it from the auto-link exclude list. Lines 354 to 357 in c3d33fc
|
@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@twisterdotcom Huh... This is 4 days overdue. Who can take care of this? |
Seems straightforward right? I haven't recreated this, so will lean on C+ too for this dev specific issue. |
Job added to Upwork: https://www.upwork.com/jobs/~021849240595196131510 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
Upwork job price has been updated to $125 |
Downgrading as this isn't customer facing. |
I'm assuming we exclude the 🎀 👀 🎀 C+ reviewed! |
Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Proposal seems good, but question: why is this only getting reported and fixed now? The PR that added that code was merged 10 months ago. Did we just live with warning until @eVoloshchak decided to report it? |
PR is ready
I think yes. There has been so much warning on the app that I think people keep ignoring them 😅 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-13. 🎊 For reference, here are some details about the assignees on this issue:
|
@mollfpr @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Payment Summary
BugZero Checklist (@twisterdotcom)
|
Requested in ND. |
@twisterdotcom @blimpich @mollfpr @bernhardoj this issue is now 4 weeks old, please consider:
Thanks! |
It is done Melv. Just waiting on @mollfpr to do the checklist, although... looking again, I don't think we need one just for this console error. Going to close. |
$125 approved for @bernhardoj |
Actually wait, going to confirm the amounts with @twisterdotcom via DM. |
Payment summary is updated and so is my approval amount. |
Sorry for the delay! Yes, we don't need the checklist here. |
$125 approved for @mollfpr |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number:
Reproducible in staging?: DEV
Reproducible in production?: DEV
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @eVoloshchak
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729174865370699
Action Performed:
Expected Result:
No warning is displayed
Actual Result:
Warning is displayed
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
![Simulator Screenshot - iPhone 15 Pro - 2024-10-17 at 16 17 56](https://github.com/user-attachments/assets/2e076611-8c45-408f-ac83-fa1e228efc92)Screen.Recording.2024-10-17.at.16.20.46.mov
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @twisterdotcomThe text was updated successfully, but these errors were encountered: