[$250] [HOLD for payment 2024-11-01] Search - Down caret icon and search icon are close to each other

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.50-4
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to FAB > Start chat.
3. Select a user with long name.
4. Submit an expense to the user.
5. Make sure that user name and expense amount are long enough to reach the search icon on the expense report header.
6. Go to expense report.

Expected Result:

There will be spacing between the down caret and search icon on the expense report header.

Actual Result:

The down caret and search icon are very close to each other.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6638169_1729198128310.ScreenRecording_10-18-2024_04-42-44_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021853588853114817182
• Upwork Job ID: 1853588853114817182
• Last Price Increase: 2024-11-05

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[SzymczakJ]

This is a small visual bug and I don't think it deserves a Deploy Blocker label. @luacmartins
I'd like to fix it since I implemented Search 2.4.

[MonilBhavsar]

Thank you! Agree, this is not really a blocker.
I will assign you to this issue

[MonilBhavsar]

Assigning @rayane-djouah as a C+ following the main PR

[Kicu]

Will provide a fix for this, please assign me

[Kicu]

fix in PR ready to check

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix small search visual bugs #51081

If no regressions arise, payment will be issued on 2024-11-01. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rayane-djouah] Determine if we should create a regression test for this bug.
• [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rayane-djouah]

BugZero Checklist

• The PR that introduced the bug has been identified. Link to the PR: Add new SearchButton to all pages and tweak SearchRouter #49379
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/49379/files#r1819616450
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. This is part of the search project, and regression tests will be added during the project wrap-up
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @Kicu is from an agency-contributor and not due payment
• ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@mallenexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021853588853114817182

[melvin-bot]

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

[mallenexpensify]

@rayane-djouah can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021853588853114817182

[incognito-root]

Proposed Solution

Will implement:

1. Add appropriate left margin to search icon for consistent spacing between icons
2. Enable text wrapping for username and amount when they exceed available width

This will ensure proper spacing while maintaining functionality across all platforms.

Testing Plan

Will verify:

1. Username/amount display:
   • Short text (spacing maintained)
   • Long text (proper wrapping)
2. All required platforms:
   • iOS/Android (Standalone, HybridApp, mWeb)
   • MacOS (Chrome/Safari, Desktop)
3. Various screen sizes

Timeline

Expected PR in 1 day

[MonilBhavsar]

The PR #51081 fixed two bugs and looks like C+ payment was issued in other issue

[melvin-bot]

📣 @incognito-root! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[incognito-root]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0135886d7cf9ca15ac

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[rayane-djouah]

The PR #51081 fixed two bugs and looks like C+ payment was issued in other issue

Correct, we can close this issue.

[MonilBhavsar]

Thanks!

[melvin-bot]

@luacmartins @mallenexpensify @MonilBhavsar Be sure to fill out the Contact List!