[HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] Invoice - Merchant and date options not displayed on confirmation page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.50.6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5095136
Issue reported by: Applause Internal Team

Action Performed:

1. Open the hybrid app (or normal NewDot app) and log in
2. Create a workspace if needed
3. Navigate to workspace settings > More features
4. Enable the Invoice feature
5. Navigate to the LHN
6. Tap FAB > Invoice
7. Enter the amount and select the user you want to send an invoice
8. Proceed to the confirmation screen

Expected Result:

The Merchant and date options are displayed on the confirmation page

Actual Result:

The Merchant and date options are missing on the confirmation page

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6638415_1729223334114.IMG_0511.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #vip-bills

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-10-18 10:24:48 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Merchant and date options are missing on the confirmation page

What is the root cause of that problem?

We fallback to selectedTab when first start the IOU flow:

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 61 in 7cd46a7

const transactionRequestType = useMemo(() => transaction?.iouRequestType ?? selectedTab, [transaction?.iouRequestType, selectedTab]);

But in case of invoice, pay or send, we do not use tab navigator. For those IOU types, the request type is always manual.

So if we previously select Distance tab in Submit expense flow, the open Send invoice, the transaction request type would be distance and cause these checks to fail (because isDistanceRequest is true):

App/src/components/MoneyRequestConfirmationList.tsx

Line 264 in 3a08cff

const shouldShowMerchant = shouldShowSmartScanFields && !isDistanceRequest && !isTypeSend;

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 244 in 3a08cff

const shouldShowDate = (shouldShowSmartScanFields || isDistanceRequest) && !isTypeSend;

That's why we also see a map showing in confirmation page if you granted location permission:

What changes do you think we should make in order to solve the problem?

Rewrite the request type logic to include the condition to use tab navigator:

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 137 in 7cd46a7

{iouType !== CONST.IOU.TYPE.SEND && iouType !== CONST.IOU.TYPE.PAY && iouType !== CONST.IOU.TYPE.INVOICE ? (

transaction?.iouRequestType ?? (iouType !== CONST.IOU.TYPE.SEND && iouType !== CONST.IOU.TYPE.PAY && iouType !== CONST.IOU.TYPE.INVOICE ? selectedTab : 'manual')

[Beamanator]

Hmm @mkzie2 I'm not seeing the map displayed like you are, and I checked that my iPhone does have location permission granted 🤔

[Beamanator]

Oh now I see it - if you select distance first, then go to the send invoice page, i do see the map 👍

[mkzie2]

Reproducible steps:

1. FAB >> Submit expense >> Distance
2. Close the RHP
3. FAB >> Send invoice
4. Complete the invoice flow
5. In confirmation page, a map shows with default location (which is Expensify headquarter); missing Merchant and Date field

@Beamanator Can you try

[Beamanator]

@mkzie2 as before, do you think you can help figure out the PR which caused this bug? I really appreciate the work you've been doing helping solve blockers recently 🙏

[mkzie2]

This one #51040 which linked to #50961.

[Beamanator]

cc @bernhardoj & @rayane-djouah as the author & C+ of #51040 - can y'all take a look here?

[Beamanator]

BTW @mkzie2 you should get compensated for the fix, assuming we go with your fix 🙏 👍

[rayane-djouah]

PR approved

[Beamanator]

Merged!

[Beamanator]

CPing soon

[bernhardoj]

Fixed in staging.

web_stg.mp4

[Beamanator]

woohoo! thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix missing merchant and date field in invoice confirm page #51083

If no regressions arise, payment will be issued on 2024-10-25. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Beamanator] The PR that introduced the bug has been identified. Link to the PR:
• [@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Beamanator] Determine if we should create a regression test for this bug.
• [@Beamanator] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rayane-djouah]

@Beamanator We can close this issue

[Beamanator]

@sakluger i believe we should pay out @mkzie2 for the solution & finding the offending PR, can you please confirm before we close this out?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix missing merchant and date field in invoice confirm page #51083

If no regressions arise, payment will be issued on 2024-10-29. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Beamanator] The PR that introduced the bug has been identified. Link to the PR:
• [@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Beamanator] Determine if we should create a regression test for this bug.
• [@Beamanator] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Just to confirm, @rayane-djouah and @bernhardoj are being paid on #50098, right?

[sakluger]

Summarizing payment on this issue:

Contributor: @mkzie2 $250, sent offer via Upwork: https://www.upwork.com/nx/wm/offer/104597365

[bernhardoj]

@sakluger yes

[sakluger]

I sent an email to @mkzie2 to remind them to accept the Upwork payment.

[mkzie2]

@sakluger Done 🙏

[sakluger]

Thank you! We're all done here.