[HOLD for payment 2024-11-11] [$250] 2FA - When open the link to 'Authenticator app link' the page shows an error

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.50
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Loggin
2. Click on 'Settings'
3. Click on 'Security'
4. Click on 'Two-factor authentication'
5. Click on 'Copy' and click on 'Next' green button
6. Click on 'authenticator app link'

Expected Result:

The user should be able to see the website

Actual Result:

When the user click on 'authenticator app link' the redirected website throws an error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6636693_1729093986769.Screen_Recording_2024-10-16_at_12.42.20_PM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021848381032815811623
• Upwork Job ID: 1848381032815811623
• Last Price Increase: 2024-10-21
• Automatic offers:
• c3024 | Reviewer | 104595326
• NJ-2020 | Contributor | 104595327

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We need to update this link to the correct one inside help.expensify.com

App/src/pages/settings/Security/TwoFactorAuth/Steps/VerifyStep.tsx

Line 25 in f7d08e0

const TROUBLESHOOTING_LINK = 'https://community.expensify.com/discussion/7736/faq-troubleshooting-two-factor-authentication-issues/p1?new=1';

App/src/pages/settings/Security/TwoFactorAuth/Steps/VerifyStep.tsx

Line 87 in f7d08e0

<TextLink href={TROUBLESHOOTING_LINK}> {translate('twoFactorAuth.authenticatorApp')}</TextLink>.

What changes do you think we should make in order to solve the problem?

We need to update the link to:
https://help.expensify.com/articles/new-expensify/settings/Enable-Two-Factor-Authentication

And we need to confirm the above link to Expensify team

What alternative solutions did you explore? (Optional)

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the user click on 'authenticator app link' the redirected website throws an error

What is the root cause of that problem?

• When open the link to 'Authenticator app link`, the below link will be opened:
  

  App/src/pages/settings/Security/TwoFactorAuth/Steps/VerifyStep.tsx

  Line 25 in 66cf824

  const TROUBLESHOOTING_LINK = 'https://community.expensify.com/discussion/7736/faq-troubleshooting-two-factor-authentication-issues/p1?new=1';

• In PR, we already have a logic to redirect app to https://help.expensify.com/articles/expensify-classic/settings/Enable-two-factor-authentication in case of https://community.expensify.com/discussion/7736/faq-troubleshooting-two-factor-authentication-issues:

App/docs/redirects.csv

Line 502 in 66cf824

https://community.expensify.com/discussion/7736/faq-troubleshooting-two-factor-authentication-issues,https://help.expensify.com/articles/expensify-classic/settings/Enable-two-factor-authentication

but because of the additional path /p1?new=1, app does not handle redirect properly.

What changes do you think we should make in order to solve the problem?

• We need to remove /p1?new=1 in:
  

  App/src/pages/settings/Security/TwoFactorAuth/Steps/VerifyStep.tsx

  Line 25 in 66cf824

  const TROUBLESHOOTING_LINK = 'https://community.expensify.com/discussion/7736/faq-troubleshooting-two-factor-authentication-issues/p1?new=1';

What alternative solutions did you explore? (Optional)

• We can use another url instead of https://community.expensify.com/discussion/7736/faq-troubleshooting-two-factor-authentication-issues/p1?new=1, it can be https://help.expensify.com/articles/new-expensify/settings/Enable-Two-Factor-Authentication. It will redirect users to articles related to ND instead of OD.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021848381032815811623

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[c3024]

Thank you for your proposals.

As far as I can see, all links are now help.expensify..... No new community links are being created, and the redirects of existing community links are for backward compatibility wherever those links are still present.

I believe it is better to replace the community link directly with the help link when we are correcting the link (or adding a redirect link) anyway. This approach seems better than adding the community and help links to redirects.csv to redirect the community link to the help link.

So, @NJ-2020 's proposal here LGTM!

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[truph01]

@c3024

• I believe the best proposal should not only offer a working solution but also provide a clear and accurate RCA.

The selected proposal doesn't explain why clicking the 'Authenticator app link' leads to an error page. Its 'What is the root cause of the problem?' and 'What changes should we make to solve it?' sections are almost identical. We should know why the bug occurs in the first place. You cannot fix something without knowing what caused it in the first place.

• In two previous issues—Issue 50299 and Issue 50065—I also provided working solutions, but my proposals were not selected because my RCA sections lacked detail.

cc @jasperhuangg Please review my thoughts?

[NJ-2020]

We also update another link from community.expensify.com to help.expensify.com here

[melvin-bot]

@jasperhuangg, @lschurr, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jasperhuangg]

I think we should stick with the NewDot help docs, so @NJ-2020's proposal looks good to me.

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @NJ-2020 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[NJ-2020]

PR ready
cc: @c3024

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix authenticator app link #51535

If no regressions arise, payment will be issued on 2024-11-11. 🎊

For reference, here are some details about the assignees on this issue:

• @NJ-2020 requires payment automatic offer (Contributor)
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot]

@c3024 @lschurr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[lschurr]

Payment summary:

• Contributor: @NJ-2020 $250 (paid in Upwork)
• Reviewer: @c3024 $250 (paid in Upwork)