Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EmojiTrie implementation to SuffixTree #51148

Open
hannojg opened this issue Oct 21, 2024 · 4 comments
Open

Change EmojiTrie implementation to SuffixTree #51148

hannojg opened this issue Oct 21, 2024 · 4 comments
Labels

Comments

@hannojg
Copy link
Contributor

hannojg commented Oct 21, 2024

For this issue ticket we have implemented a very efficient/fast suffix tree implementation:

PR:

It was discussed that we want to use the implementation of the SuffixTree for the emoji search as well:

This enables:

  • more efficient search in emojis
  • faster construction of the emoji tree (we should compare the construction time before and after the change.)
  • searching for any substring of an emoji name (not just perfect name matches)
@hannojg
Copy link
Contributor Author

hannojg commented Oct 21, 2024

cc @roryabraham

@ChavdaSachin
Copy link
Contributor

ChavdaSachin commented Oct 21, 2024

Hey @hannojg, I have been very passionate Competitive Programmer back during my college days.
I think I could be a help here.
Do you think there is a scope for an External contributor here?

@hannojg
Copy link
Contributor Author

hannojg commented Oct 21, 2024

I think this is more of an internal ticket. The suffix tree implementation has already been built by our internal team and this is a follow up issue from one of our PRs.

@ChavdaSachin
Copy link
Contributor

Alright,
But I have one more suggestion here, we could make use of c++ here instead of js , c++ is well known for it's speed, I am really positive that c++ would make significant improvement here.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants