Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - Search does not returns group when entering group members #51175

Closed
2 of 8 tasks
IuliiaHerets opened this issue Oct 21, 2024 · 9 comments · Fixed by #51177
Closed
2 of 8 tasks

Search - Search does not returns group when entering group members #51175

IuliiaHerets opened this issue Oct 21, 2024 · 9 comments · Fixed by #51177
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 21, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.51-2
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5107189&group_by=cases:section_id&group_order=asc&group_id=229066
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Create group chat and invite two users (for example [email protected], and [email protected])
  2. Go to chat search and enter member's emails ( [email protected] and [email protected])

Expected Result:

The search should displays the group

Actual Result:

Search does not returns group when entering group members

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bandicam.2024-10-21.14-16-11-666.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 21, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Oct 21, 2024

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 21, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 21, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mjasikowski
Copy link
Contributor

checking

@mjasikowski
Copy link
Contributor

caused by #48652 according to git bisect

@mjasikowski
Copy link
Contributor

Revert in progress

@mjasikowski
Copy link
Contributor

FYI this happens when group member names are separated by whitespace only. It works fine if you enter the names separated by comma and a space (like they are in the group chat title), but nevertheless - this is a bug.

@hannojg
Copy link
Contributor

hannojg commented Oct 23, 2024

Huh the PR has been reverted and is said to be deployed to staging. If i try to reproduce this on staging it seems like I can't retrieve a group by searching for its members there either:

Screen.Recording.2024-10-23.at.15.02.57.mov

if i am not mistaken a few weeks ago the functionality to search for groups/reports by their participants had been removed here:

Screenshot 2024-10-23 at 15 01 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants