Login - Login with new gmail account, user directed to concierge chat

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: V9. 0.51-2
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Login with a new gmail account
3. Finish onboarding by selecting "something else"
4. Enter first name and complete the flow

Expected Result:

Login with new gmail account, user must be directed to LHN.

Actual Result:

Login with new gmail account, user directed to concierge page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6640890_1729508215326.Screenrecorder-2024-10-21-16-18-32-574_compress_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login - Login with new gmail account, user directed to concierge chat

What is the root cause of that problem?

We don't wrap this inside if statement to check if the shouldUseNarrowLayout is false

App/src/libs/navigateAfterOnboarding.ts

Line 37 in f28662e

Navigation.navigate(lastAccessedReportRoute);

Because after we complete the onboarding flow the lastAccessedReportID return the concierge report id because if the user join for the first time the user could have a concierge and if yes we will return the concierge chat

App/src/libs/ReportUtils.ts

Lines 1354 to 1357 in f28662e

	function findLastAccessedReport(ignoreDomainRooms: boolean, openOnAdminRoom = false, policyID?: string, excludeReportID?: string): OnyxEntry<Report> {
	// If it's the user's first time using New Expensify, then they could either have:
	// - just a Concierge report, if so we'll return that
	// - their Concierge report, and a separate report that must have deeplinked them to the app before they created their account.

And also as we can see here that we wrap the navigateToConciergeChat util function inside if statement to check if the shouldUseNarrowLayout is false before navigating

App/src/libs/navigateAfterOnboarding.ts

Lines 30 to 32 in f28662e

	if (!shouldUseNarrowLayout && !backTo) {
	Report.navigateToConciergeChat();
	}

What changes do you think we should make in order to solve the problem?

We should wrap it inside if statement to check if the shouldUseNarrowLayout is false before navigating

if (!shouldUseNarrowLayout) {
    Navigation.navigate(lastAccessedReportRoute);
}

What alternative solutions did you explore? (Optional)

Alternatively we can wrap the entire navigation system inside the if statement and check if the shouldUseNarrowLayout is false

if (!shouldUseNarrowLayout) {
    if (!lastAccessedReportID || lastAccessedReport.policyID === onboardingPolicyID) {
        if (!backTo) {
            Report.navigateToConciergeChat();
        }
        return;
    }

    const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID ?? '-1');
    Navigation.navigate(lastAccessedReportRoute);
}

[RachCHopkins]

This is not a bug. As part of Guided Setup we end with Concierge. If they don't do the other steps, then they start with Concierge:

And then they can message for advice on what to do.