[HOLD for payment 2024-11-13] [$250] iOS - Search - Search page cannot be dismissed by swiping to the right

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.51-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch hybrid app (or standalone ND app)
2. Tap on the search icon on the top right
3. Swipe to the right to dismiss the search page (iOS swiping style)

Expected Result:

The search page can be dismissed by swiping to the right (the old Find page can be dismissed by swiping to the left)

Actual Result:

The search page cannot be dismissed by swiping to the right

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6641265_1729531612859.1729531201791_20241022_011757.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851376677882025777
• Upwork Job ID: 1851376677882025777
• Last Price Increase: 2024-10-29

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[QichenZhu]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Swiping to the right doesn't dismiss the search modal on iOS.

What is the root cause of that problem?

Swiping is disabled on purpose in the line below.

App/src/components/Search/SearchRouter/SearchRouterModal.tsx

Line 14 in 4f0ca94

const modalType = shouldUseNarrowLayout ? CONST.MODAL.MODAL_TYPE.CENTERED_UNSWIPEABLE : CONST.MODAL.MODAL_TYPE.POPOVER;

What changes do you think we should make in order to solve the problem?

Simply setting the type to CONST.MODAL.MODAL_TYPE.CENTERED would make the modal swipable, but it might not be the right solution.

We need to understand why swiping was disabled first, maybe with the help of the original committer @SzymczakJ, and resolve their concerns.

What alternative solutions did you explore? (Optional)

N/A

[SzymczakJ]

Yes, I've set modal type to CENTRED_UNSWIPABLE on purpose because SelectionList behaved really strange(go on and test it yourself) on CENTRED modal. I didn't realise that it will break the swipe right pattern on iOS though.
Unfortunately I don't have a straightforward solution for this, I guess we will have to fix SelectionList behaviour on CENTRED_UNSWIPABLE modals.
I could take a look at it, after finishing this PR #51237, so it can take me like 1-2 days.

[melvin-bot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[SzymczakJ]

FYI I started looking at this, feel free to assign me.

[melvin-bot]

@anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851376677882025777

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[anmurali]

I'll let @ishpaul777 review proposals

[QichenZhu]

Please check out the comment by @SzymczakJ from Software Mansion.

[ishpaul777]

okay i'll let @SzymczakJ investigate as author of PR which intrduced this, @SzymczakJ Please keep us updated!

[SzymczakJ]

Fix ready for your review @ishpaul777 😄

[ishpaul777]

Thanks, i'll review in couple hours today

[melvin-bot]

Triggered auto assignment to @pecanoro, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make SearchRouter swipable to the right #51731

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

@ishpaul777 @anmurali The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @MitchExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@MitchExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1851376677882025777/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@pecanoro, @MitchExpensify, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ishpaul777]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: was done on purpose during feature implementation

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/50143/files#r1845562712

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not critical being done purpose, user can still able to go back using < button on top left so this doesn't block any user action

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. - For same reason as above no regression test needed

[MitchExpensify]

offer sent @ishpaul777 !

[melvin-bot]

@pecanoro, @MitchExpensify, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[ishpaul777]

I have accepted the offer 🙇

[MitchExpensify]

Paid / contract ended, thanks @ishpaul777