[HOLD for payment 2024-11-07] [$125] Update the Onboarding steps for "Chat and split bills with friends"

[zsgreenwald]

Problem

The steps presented currently expose dated functionality and that isn't available in-app anymore. This causes user-confusion for anyone that selects that onboarding intent.

Solution

Update the onboarding steps for the Task - Split an expense to:

Split an expense right in your chat with one or more friends.

Here’s how to request money:

1. Hit the green + button
2. Choose "Start chat"
3. Enter any email, SMS, or name of who you want to split with
4. From within the chat, hit the + button on the message bar, and hit Split expense
5. Create the expense by selecting Manual, Scan or Distance

Feel free to add more details if you want, or just send it off. Let’s get you paid back!

cc: @mallenexpensify @vitHoracek as we'll be tapping C+ for this

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854295488284084894
• Upwork Job ID: 1854295488284084894
• Last Price Increase: 2024-11-06

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[nyomanjyotisa]

Edited by proposal-police: This proposal was edited at 2024-10-22 02:23:15 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the Onboarding steps for "Chat and split bills with friends"

What is the root cause of that problem?

Changes Request

What changes do you think we should make in order to solve the problem?

We need update the splitExpense here

                {
                    type: 'splitExpense',
                    autoCompleted: false,
                    title: 'Split an expense',
                    description:
                        '*Split an expense* right in your chat with one or more friends.\n' +
                        '\n' +
                        'Here’s how to request money:\n' +
                        '\n' +
                        '1. Hit the green *+* button.\n' +
                        '2. Choose *Start chat*.\n' +
                        '3. Enter any email, SMS, or name of who you want to split with.\n' +
                        '4. From within the chat, hit the *+* button on the message bar, and hit *Split expense*.\n' +
                        '5. Create the expense by selecting Manual, Scan or Distance.\n' +
                        '\n' +
                        'Feel free to add more details if you want, or just send it off. Let’s get you paid back!',
                },

RESULT

What alternative solutions did you explore? (Optional)

[ChavdaSachin]

Edited by proposal-police: This proposal was edited at 2024-10-22 05:50:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the Onboarding steps for "Chat and split bills with friends"

What is the root cause of that problem?

General Update

What changes do you think we should make in order to solve the problem?

I propose to include this task with Spanish translation, and translate all the other onboarding tasks to Spanish as well(could be handled as separate PR if needed).
Something like....

                {
                    type: 'splitExpense',
                    autoCompleted: false,
                    title: Translate('onboarding.tasks.splitExpense.title'),
                    description:
                        Translate('onboarding.tasks.splitExpense.description'),
                },

App/src/CONST.ts

Lines 4819 to 4834 in 04214cd

	{
	type: 'splitExpense',
	autoCompleted: false,
	title: 'Split an expense',
	description:
	'*Split an expense* right in your chat with one or more friends.\n' +
	'\n' +
	'Here’s how to request money:\n' +
	'\n' +
	'1. Click the green *+* button.\n' +
	'2. Choose *Split expense*.\n' +
	'3. Scan a receipt or enter an amount.\n' +
	'4. Add your friend(s) to the request.\n' +
	'\n' +
	'Feel free to add more details if you want, or just send it off. Let’s get you paid back!',
	},

Add this to en.ts here

tasks: {
     splitExpense: {
          title: 'Split an expense',
          description: 
                 '*Split an expense* right in your chat with one or more friends.\n' +
                        '\n' +
                        'Here’s how to request money:\n' +
                        '\n' +
                        '1. Hit the green *+* button.\n' +
                        '2. Choose *Start chat*.\n' +
                        '3. Enter any email, SMS, or name of who you want to split with.\n' +
                        '4. From within the chat, hit the *+* button on the message bar, and hit *Split expense*.\n' +
                        '5. Create the expense by selecting Manual, Scan or Distance.\n' +
                        '\n' +
                        'Feel free to add more details if you want, or just send it off. Let’s get you paid back!',
          }
}

and update es.ts accordingly.

• Translating everything related to onboarding tasks would additionally solve this issue as well

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Triggered auto assignment to @danielrvidal (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

[mallenexpensify]

@danielrvidal , added Waiting for copy for 👀 on copy in the OP.
@ikevin127 are you doing the work here as the contributor or will you be reviewing proposals and the PR?

I assigned myself as BZ since I was tagged and have context

[ikevin127]

@mallenexpensify I will be taking over as C+ reviewing the proposals. While we're waiting for confirmation on copy, I will start reviewing the proposals.

[melvin-bot]

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[mallenexpensify]

One more thing @ikevin127 this looks like a simple text update so I set it at $125. Let me know if I'm missing something

[ikevin127]

Given that there's no mention about translations in the OP, the codebase shows no indication of translating any of the ONBOARDING_MESSAGES as we keep them in CONST instead of translation files, I'd say let's go with @nyomanjyotisa's proposal as this is a simple copy replacement task.

I think moving / translating all ONBOARDING_MESSAGES would be out of scope for this issue. @ChavdaSachin if you want to do that you'd have a better chance in this issue, so I'd recommend you to post a proposal there.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[danielrvidal]

The copy looks good in the proposals. I was going to note Split expense should be bolded in #4 but it looks like the proposals account for that. I'm unassigning myself but please add me back if needed.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update the Onboarding steps for 'Chat and split bills with friends' #51340

If no regressions arise, payment will be issued on 2024-11-07. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)
• @nyomanjyotisa requires payment (Needs manual offer from BZ)

[melvin-bot]

@ikevin127 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[ikevin127]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Outdated copy

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Not needed in this case as this was a copy update change and not a fix for a regression.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not needed in this case as this was a copy update change.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

I don't think regression test is needed here because this was a copy update change, but if required I'd be happy to provide the PRs testing steps.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[melvin-bot]

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021854295488284084894

[melvin-bot]

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mallenexpensify]

Contributor: @nyomanjyotisa paid $125 via Upwork
Contributor+: @ikevin127 paid $125 via Upwork

@VictoriaExpensify I'm off the next week, can you please keep an eye on this issue til I'm back? Thx @nyomanjyotisa needs to accept the upwork job and @ikevin127 needs to propose details for the test case.

[ikevin127]

@mallenexpensify Offer accepted, thank you!

Regarding regression test, I mentioned in the checklist #51215 (comment):

I don't think regression test is needed here because this was a copy update change, but if required I'd be happy to provide the PRs testing steps.

If what you mean above is that we indeed need to regression test then I'll write it up before payment is due.

[mallenexpensify]

ah.. sorry, def missed that @ikevin127

I paid @nyomanjyotisa so we're good to close, thx Vic! ;)