Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold #51657][$250] Expense - Header shows skeleton and LHN shows Hidden when deleting expense with comment #51474

Open
5 of 8 tasks
lanitochka17 opened this issue Oct 25, 2024 · 21 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 25, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.54-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5131224
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Submit expense > Manual
  3. Submit expense to any user with no unsettled expense
  4. Go to transaction thread
  5. Send a message
  6. Click on the report header > Delete expense
  7. Delete the expense

Expected Result:

Header, LHN report title and thread parent message will show {Deleted message]

Actual Result:

  • Header shows skeleton
  • LHN report title shows Hidden
  • Thread parent message is empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Uploading Bug6645540_1729860193572!20241025_203818.mp4…

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021851087295209337215
  • Upwork Job ID: 1851087295209337215
  • Last Price Increase: 2024-10-29
Issue OwnerCurrent Issue Owner: @trjExpensify
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2024
Copy link

melvin-bot bot commented Oct 28, 2024

@trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@trjExpensify
Copy link
Contributor

@lanitochka17 can I get a video of this bug please, as the one in the OP failed to attach.

@melvin-bot melvin-bot bot removed the Overdue label Oct 29, 2024
@trjExpensify
Copy link
Contributor

Alright, I can repro this:

2024-10-29_02-21-20.mp4

@trjExpensify trjExpensify added the External Added to denote the issue can be worked on by a contributor label Oct 29, 2024
@melvin-bot melvin-bot bot changed the title Expense - Header shows skeleton and LHN shows Hidden when deleting expense with comment [$250] Expense - Header shows skeleton and LHN shows Hidden when deleting expense with comment Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021851087295209337215

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

@FitseTLT
Copy link
Contributor

I think a BE bug same root cause as #51657 (comment)

Copy link

melvin-bot bot commented Nov 1, 2024

@trjExpensify, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2024
@trjExpensify trjExpensify added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 4, 2024
@trjExpensify
Copy link
Contributor

Ah okay, so then I'll take Help wanted off and put it on hold for the other issue.

@trjExpensify trjExpensify changed the title [$250] Expense - Header shows skeleton and LHN shows Hidden when deleting expense with comment [Hold #51657][$250] Expense - Header shows skeleton and LHN shows Hidden when deleting expense with comment Nov 4, 2024
@trjExpensify
Copy link
Contributor

Switched over the star on this issue to me for now, Melv.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 4, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

@trjExpensify, @allgandalf 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@trjExpensify
Copy link
Contributor

Still held.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 12, 2024
@allgandalf
Copy link
Contributor

Still held..

Copy link

melvin-bot bot commented Nov 15, 2024

@trjExpensify, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@trjExpensify
Copy link
Contributor

Still held, dropping to weekly while we wait.

@melvin-bot melvin-bot bot removed the Overdue label Nov 15, 2024
@trjExpensify trjExpensify added Weekly KSv2 Overdue and removed Daily KSv2 labels Nov 15, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 25, 2024
@trjExpensify
Copy link
Contributor

No change.

@melvin-bot melvin-bot bot removed the Overdue label Nov 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 4, 2024
@trjExpensify
Copy link
Contributor

Dropping to Monthly until that gets picked up.

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2024
@trjExpensify trjExpensify added Monthly KSv2 Overdue and removed Weekly KSv2 labels Dec 4, 2024
@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2024
@allgandalf
Copy link
Contributor

@trjExpensify should i unassign myself here ?

@trjExpensify
Copy link
Contributor

Can do man, probably going to be a hot minute.

@allgandalf allgandalf removed their assignment Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
Development

No branches or pull requests

4 participants