Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [Custom feeds] Feed details explanations are missing #51563

Closed
mountiny opened this issue Oct 28, 2024 · 18 comments
Closed

[$250] [Custom feeds] Feed details explanations are missing #51563

mountiny opened this issue Oct 28, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@mountiny
Copy link
Contributor

mountiny commented Oct 28, 2024

Reported here - find more details in the slack thread

BUG: Feed details pages for Visa/Mastercard/Amex are all missing the explainers that link to where to find the fields

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021857093201326774795
  • Upwork Job ID: 1857093201326774795
  • Last Price Increase: 2024-11-14
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @allgandalf
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 28, 2024
Copy link

melvin-bot bot commented Oct 28, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny
Copy link
Contributor Author

No payments needed

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@muttmuure muttmuure moved this to MEDIUM in [#whatsnext] #quality Oct 28, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 28, 2024
@VickyStash
Copy link
Contributor

The PR has been opened for the review.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 7, 2024
@melvin-bot melvin-bot bot changed the title [Custom feeds] Feed details explanations are missing [HOLD for payment 2024-11-14] [Custom feeds] Feed details explanations are missing Nov 7, 2024
Copy link

melvin-bot bot commented Nov 7, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 7, 2024
Copy link

melvin-bot bot commented Nov 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 7, 2024

@allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

Issue is ready for payment but no BZ is assigned. @joekaufmanexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Nov 14, 2024

Payment Summary

Upwork Job

  • Contributor: @VickyStash is from an agency-contributor and not due payment
  • ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@joekaufmanexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@joekaufmanexpensify joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Nov 14, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-11-14] [Custom feeds] Feed details explanations are missing [$250] [HOLD for payment 2024-11-14] [Custom feeds] Feed details explanations are missing Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021857093201326774795

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

@joekaufmanexpensify joekaufmanexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 14, 2024
@joekaufmanexpensify
Copy link
Contributor

Only payment is $250 to @allgandalf for C+ via Upwork

@joekaufmanexpensify
Copy link
Contributor

@allgandalf offer sent for $250!

@allgandalf
Copy link
Contributor

@joekaufmanexpensify this is part of cleanup project, please revert the offer and i will post checklist in sometime, i will request payment at the last

@joekaufmanexpensify
Copy link
Contributor

Ah, I see. So you're being paid in bulk?

@mountiny
Copy link
Contributor Author

@joekaufmanexpensify Yes I have talked with @allgandalf @DylanDylann @dukenv0307 so we are going to collect all the issues and manage the payment in the end as that will be easier than handling this on individual issues. We also agreed that the base price will be $125 since there is plenty of these and they are often small and we can change to $250 on case by case basis

Once the checklist is complete, we can close

@joekaufmanexpensify
Copy link
Contributor

Makes sense! Will look out for the checklist then and close after

@joekaufmanexpensify joekaufmanexpensify changed the title [$250] [HOLD for payment 2024-11-14] [Custom feeds] Feed details explanations are missing [$250] [Custom feeds] Feed details explanations are missing Nov 15, 2024
@joekaufmanexpensify
Copy link
Contributor

I actually don't think we need the checklist here. This wasn't introduced anywhere, it just got missed during implementation. Further, I already have this case covered in the manual test script, so it will be codified into a regression test when I pass those off to Applause. We should be all set here. TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Development

No branches or pull requests

5 participants