-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-07] [$125] Update the intent video for Get paid back from my employer
#51603
Comments
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 ( |
For https://github.com/Expensify/Expensify/issues/432811 [Internal only design issue] |
Get paid back from my employer
Get paid back from my employer
|
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext. |
Job added to Upwork: https://www.upwork.com/jobs/~021850986914069355403 |
Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Update the intent video for Get paid back from my employer What is the root cause of that problem?Improvement What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)Result |
@anmurali, we need to upload the new video to Line 89 in 3540a3b
|
@abdulrahuman5196, @nikihatesgh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
The video has been added here: https://github.com/Expensify/Web-Static/blob/main/videos/guided-setup-get-paid-back-v3.mp4 |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@Krishna2323 - can you update the video in product now? |
The url should be Edit: currently broken, should be fixed tomorrow - will post an update when the fixed url is live. |
@abdulrahuman5196, @nikihatesgh Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@abdulrahuman5196 is there any update here? |
Checking now |
@Krishna2323 's proposal here #51603 (comment) looks good and works well. Since this is a straightforward change, going with the first proposal. 🎀 👀 🎀 |
Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
I thought we already had a PR in progress for this? I may have confused with something else though. Anyway, pretty straightforward change, let's get this done 🚀 |
📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@abdulrahuman5196, PR ready for review ^ |
Get paid back from my employer
Get paid back from my employer
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-07. 🎊 For reference, here are some details about the assignees on this issue:
|
Issue is ready for payment but no BZ is assigned. @RachCHopkins you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks! |
Payment Summary:
Upwork job here |
Contributor has been paid, the contract has been completed, and the Upwork post has been closed. |
$125 approved for @abdulrahuman5196 |
Update the intent video shown by Concierge when someone selects
Get paid back from my employer
. Right now it shows a manual request and we want it to show a receipt being scanned.GIF version MP4 version
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @abdulrahuman5196The text was updated successfully, but these errors were encountered: