Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-07] [$125] Update the intent video for Get paid back from my employer #51603

Closed
anmurali opened this issue Oct 28, 2024 · 32 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@anmurali
Copy link

anmurali commented Oct 28, 2024

Update the intent video shown by Concierge when someone selects Get paid back from my employer. Right now it shows a manual request and we want it to show a receipt being scanned.

GIF version MP4 version

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021850986914069355403
  • Upwork Job ID: 1850986914069355403
  • Last Price Increase: 2024-11-11
  • Automatic offers:
    • Krishna2323 | Contributor | 104920383
Issue OwnerCurrent Issue Owner: @abdulrahuman5196
@anmurali anmurali added External Added to denote the issue can be worked on by a contributor Daily KSv2 labels Oct 28, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 28, 2024
Copy link

melvin-bot bot commented Oct 28, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@anmurali
Copy link
Author

For https://github.com/Expensify/Expensify/issues/432811 [Internal only design issue]

@anmurali anmurali changed the title Update the intent video for Get paid back from my employer [$125] Update the intent video for Get paid back from my employer Oct 28, 2024
Copy link

melvin-bot bot commented Oct 28, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@anmurali anmurali added Engineering and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Oct 28, 2024
Copy link

melvin-bot bot commented Oct 28, 2024

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

@anmurali anmurali added External Added to denote the issue can be worked on by a contributor and removed Engineering labels Oct 28, 2024
Copy link

melvin-bot bot commented Oct 28, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021850986914069355403

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 28, 2024
Copy link

melvin-bot bot commented Oct 28, 2024

Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new.

@Krishna2323
Copy link
Contributor

Proposal


Please re-state the problem that we are trying to solve in this issue.

Update the intent video for Get paid back from my employer

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?


  • We first need to upload the video to cloudfront.
  • Then update the url below with the new video url.
    url: `${CLOUDFRONT_URL}/videos/guided-setup-get-paid-back-v2.mp4`,

What alternative solutions did you explore? (Optional)

Result

@Krishna2323
Copy link
Contributor

Krishna2323 commented Oct 28, 2024

@anmurali, we need to upload the new video to https://d2k5nsl2zxldvw.cloudfront.net/ and then we can replace the url below with the new one. Or if we have already uploaded the video on Cloudfront then we need the url of the new video.

url: `${CLOUDFRONT_URL}/videos/guided-setup-get-paid-back-v2.mp4`,

@nikihatesgh nikihatesgh self-assigned this Oct 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

@abdulrahuman5196, @nikihatesgh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@nikihatesgh
Copy link

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 1, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@anmurali
Copy link
Author

anmurali commented Nov 4, 2024

@Krishna2323 - can you update the video in product now?

@Krishna2323
Copy link
Contributor

@anmurali, we need the url of the video uploaded to cloudfront. like this one.

@NikkiWines
Copy link
Contributor

NikkiWines commented Nov 5, 2024

The url should be ${CLOUDFRONT_URL}/videos/guided-setup-get-paid-back-v3.mp4

Edit: currently broken, should be fixed tomorrow - will post an update when the fixed url is live.

Copy link

melvin-bot bot commented Nov 5, 2024

@abdulrahuman5196, @nikihatesgh Whoops! This issue is 2 days overdue. Let's get this updated quick!

@nikihatesgh
Copy link

@abdulrahuman5196 is there any update here?

@melvin-bot melvin-bot bot removed the Overdue label Nov 15, 2024
@abdulrahuman5196
Copy link
Contributor

Checking now

@abdulrahuman5196
Copy link
Contributor

@Krishna2323 's proposal here #51603 (comment) looks good and works well. Since this is a straightforward change, going with the first proposal.

🎀 👀 🎀
C+ Reviewed

Copy link

melvin-bot bot commented Nov 15, 2024

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@francoisl
Copy link
Contributor

I thought we already had a PR in progress for this? I may have confused with something else though. Anyway, pretty straightforward change, let's get this done 🚀

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 15, 2024
Copy link

melvin-bot bot commented Nov 15, 2024

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 17, 2024
@Krishna2323
Copy link
Contributor

@abdulrahuman5196, PR ready for review ^

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 30, 2024
@melvin-bot melvin-bot bot changed the title [$125] Update the intent video for Get paid back from my employer [HOLD for payment 2024-12-07] [$125] Update the intent video for Get paid back from my employer Nov 30, 2024
Copy link

melvin-bot bot commented Nov 30, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 30, 2024
Copy link

melvin-bot bot commented Nov 30, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-07. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 7, 2024
Copy link

melvin-bot bot commented Dec 7, 2024

Issue is ready for payment but no BZ is assigned. @RachCHopkins you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@RachCHopkins
Copy link
Contributor

Payment Summary:

Upwork job here

@RachCHopkins
Copy link
Contributor

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

@JmillsExpensify
Copy link

$125 approved for @abdulrahuman5196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

9 participants