[HOLD for payment 2024-11-11] [HOLD for payment 2024-11-07] Room - Unable to type anything in the search field in Members page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.55-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a room
3. Invite 8 members to the room
4. Click on the room chat header
5. Click Members
6. Enter anything on the search field

Expected Result:

User should be able to type in the search field in Members page

Actual Result:

User is unable to type anything in the search field in Members page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6649415_1730210235481.20241029_215450.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

Production:

Recording.2646.mp4

[bondydaa]

nothing stands out to me from the checklist immediately, trying to dive in deeper on a few to see if they're related.

[bondydaa]

i believe this is the component https://github.com/expensify/app/blob/main/src/pages/RoomMembersPage.tsx

[bondydaa]

the search input only shows when there are 8 or more based on this logic

App/src/pages/RoomMembersPage.tsx

Line 195 in 65fa00a

return activeParticipants.length >= CONST.SHOULD_SHOW_MEMBERS_SEARCH_INPUT_BREAKPOINT;

but the PR that added that has been live for months (and should be on prod already) so it makes me think there is something within one of the nested/base components of SelectionListWithModal that might have changed but even there I don't really see any recent, staging only changes for SelectionList or BaseSelectionList

[bondydaa]

asked for help here https://expensify.slack.com/archives/C01GTK53T8Q/p1730219259911659?thread_ts=1730210923.463089&cid=C01GTK53T8Q

i need to focus on other tasks for now.

[bondydaa]

Thanks @grgia for #51684, just merged that. requesting a CP now.

https://expensify.slack.com/archives/C07J32337/p1730228354665339

[bondydaa]

i tested on staging and seems to be working.

2024-10-29_13-24-31.mp4

asked for QA to retest as we 🙏

[kavimuru]

Tester can still reproduce in #announce room but not in the other rooms.

20241030_052325.mp4

[bondydaa]

ah I see why, looks like that is using this page https://github.com/expensify/app/blob/main/src/pages/ReportParticipantsPage.tsx which is very similar to https://github.com/expensify/app/blob/main/src/pages/RoomMembersPage.tsx which is what we already fixed. I think the fix is the same thing as i see the debouncedState in the ReportParticipantsPage file.

[bondydaa]

new PR here #51702

[bondydaa]

i'll be signing off shortly, left a note for beaman in the #deployer channel about this one. i believe we just need to review, merge, CP #51702 to fix this.

[bondydaa]

bumped the qa thread to retest this again since most recent fix has been CP'd so this should be fixed https://expensify.slack.com/archives/C9YU7BX5M/p1730307374065539?thread_ts=1730229556.632319&cid=C9YU7BX5M

[kavimuru]

Not reproducible

Recording.2082.mp4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Allow input on members page #51684
• [CP stg] Report Participant Page - remove debounce to allow member search #51702

If no regressions arise, payment will be issued on 2024-11-07. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Allow input on members page #51684
• [CP stg] Report Participant Page - remove debounce to allow member search #51702

If no regressions arise, payment will be issued on 2024-11-11. 🎊

[suneox]

Hi @bondydaa I've reviewed this PR, so can I receive any offer? Thanks!