-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [HOLD for payment 2024-12-03] Got logged out of the app in web staging #51707
Comments
Triggered auto assignment to @mallenexpensify ( |
Triggered auto assignment to @MarioExpensify ( |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
Got it again today. |
Another weird thing:
so why 404 but with onyx data? Logs for that request are here |
Odd about that request:
Why would it think it's a public room? |
Ohhh probably because of:
Why I have no authToken or email?!? |
@MarioExpensify @iwiznia any chance this can be worked on Externally? Guessing not |
Hey @mallenexpensify @iwiznia, I still haven't got a chance to take a look at this one in detail. I'll try to reproduce it locally (possibly later today) and report back. |
I get this every day or really every time I close my computer and come back a few hours later. |
I know I was on staging.new.expensify.com yesterday in Chrome cuz I was testing. Just hopped on there again and didn't got logged off. Site's wonky right now though, so likely not the best time to test :/ |
Triggered auto assignment to @slafortune ( |
👋 can someone assign me here for payment please, I reviewed the linked PR |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-03. 🎊 For reference, here are some details about the assignees on this issue:
|
@allgandalf @mallenexpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
@mallenexpensify @neil-marcellini do we need a checklist for this one? |
I don't know if we need a test case for this which means.... we should create one and let QA decide if they want to add or update one in TestRail. Can you propose the regression test steps please @allgandalf ? |
Payment Summary
BugZero Checklist (@mallenexpensify)
|
Job added to Upwork: https://www.upwork.com/jobs/~021864120074677263168 |
Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new. |
@allgandalf can you please accept the job and reply here once you have? |
Regression Test Proposal
Verify you are not logged out
Verify you are not logged out Do we agree 👍 or 👎 |
@neil-marcellini @mallenexpensify not super sure what the exact testing steps would be. This issue is for extreme cases like the user is having a really bad connection and we make reauthentication calls used to fail. so do let me know if you guys have a better test in mind |
Thx @allgandalf , I agree with you, this is a bit extreme + edge case so a test is tricky. I created the test case and will let QA decide what's best. |
Contributor+: @allgandalf paid $250 via Upwork |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1730209919216239
Action Performed:
Expected Result:
User able to use the app without any issue
Actual Result:
User got log out of the app
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: