-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update transaction violations when the money request is paid #51770
Conversation
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Will this require a C+ review? |
Yes, please! But let's wait until the BE fix is deployed |
No worries! |
BE PR was deployed, and now this one is ready for review @allgandalf |
That's cool, I will start review today |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-11-25.at.12.24.47.PM.movAndroid: mWeb ChromeScreen.Recording.2024-11-25.at.12.18.37.PM.moviOS: NativeScreen.Recording.2024-11-25.at.12.17.21.PM.moviOS: mWeb SafariScreen.Recording.2024-11-08.at.4.29.40.PM.movMacOS: Chrome / SafariScreen.Recording.2024-11-08.at.4.24.56.PM.movMacOS: DesktopScreen.Recording.2024-11-08.at.4.27.37.PM.mov |
@marcochavezf can you update the testing steps to mention that the QA should be on |
Bug? : RBR is not cleared on report preview when we pay the expense, we should fix this no @marcochavezf ? |
Oh interesting I will check it out today, thanks for catching that |
All good, let me know when you have an update |
@marcochavezf any luck looking into the bug? |
Is this happening offline, right? Because the RBR is cleared out after I pay the expense: Screen.Recording.2024-11-15.at.1.25.03.p.m.movCan you share a video how you're getting the error? 🙏🏽 |
this slipped through the cracks i will check today |
i guess that workspace i tested with was connected with a accounting software so something was odd there, i tested on new workspace and this doesn't happen.
This works fine now Screen.Recording.2024-11-21.at.7.58.31.PM.movI will complete the checklist now |
@marcochavezf can you merge main, there are many issues on the current branch for native devices |
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well both online and offline, LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and tests well on web 👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.67-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.67-9 🚀
|
On hold for https://github.com/Expensify/Web-Expensify/pull/44222Explanation of Change
Fixed Issues
$ #51141
PROPOSAL: #51141 (comment)
Tests
Pre-requisite: The account should be on
canUseDupeDetection
Offline tests
Same test steps go offline before the money request is paid
QA Steps
Same as test and offline steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Offline:
1 request:
Screen.Recording.2024-10-30.at.4.02.26.p.m.mov
2 requests:
Screen.Recording.2024-10-30.at.4.01.44.p.m.mov
MacOS: Desktop