-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS - Use "rich" notifications with avatar and room for new experience HybridApp users #51846
Comments
Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new. |
This will be a good task for our SWM team. |
Yeah this is working for Android, I'll update the description 👍 |
@JmillsExpensify, @Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
iOS notifications are tough to test. Our best bet would be to ask an engineer who has already worked on HybridApp notifications, but the initial SWM HybridApp guys are all working on much more critical tasks at the moment. |
We need an internal engineer for this. I am working on a P/S for making noticiation DevX easier -- I think it makes sense to hold this issue until the tooling is better and use it as motivation for that project. |
@JmillsExpensify @Julesssss this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Reducing priority as I don't think this needs a daily update. But DevX improvements for notifications are incoming, and I think align quite closely with #quality -- more details to follow shortly! |
Starting some work on this today. For iOS we're going to need to
|
I made another issue to make Apple developer console changes for this here. Gonna need a deployer to make the changes. I'm blocked on development until that's done. |
This is nearly done just need to do final tests and I'll post the PR for review. |
Out for review! |
@JmillsExpensify, @arosiclair Whoops! This issue is 2 days overdue. Let's get this updated quick! |
This is all done! |
For iOS users with tryNewDot enabled and that use HybridApp, we're not delivering "rich" notifications that include the user's avatar and a clarification of what room the conversation is happening in. Here's two examples, one is a DM and another convo is a "test" discussion happening in a room/workspace chat.
In contract, whenever:
Then we should be sending notifications that look like this.
The text was updated successfully, but these errors were encountered: