Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LHN Mismatch] Send SetCollection instead of MergeCollection #51870

Closed
puneetlath opened this issue Nov 1, 2024 · 5 comments
Closed

[LHN Mismatch] Send SetCollection instead of MergeCollection #51870

puneetlath opened this issue Nov 1, 2024 · 5 comments
Assignees
Labels
NewFeature Something to build that is a new item. Weekly KSv2

Comments

@puneetlath
Copy link
Contributor

We are going to be changing the behavior of OpenApp/ReconnectApp when it does a full reconnect to replace the full reports list that the client has stored instead of merging with it.

To do this, we will first need to make the client-side changes in #51864 and #51867. Once those are done, we will want to:

  1. Make sure all apps, including HybridApp, are updated to a version that supports both of the above changes
  2. Set a minimum api version that supports the above changes
  3. Update ReconnectApp to start returning SetCollection instead of MergeCollection when doing a full reconnect
@puneetlath puneetlath added Weekly KSv2 NewFeature Something to build that is a new item. labels Nov 1, 2024
@puneetlath puneetlath self-assigned this Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

@puneetlath puneetlath moved this to CRITICAL in [#whatsnext] #quality Nov 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@puneetlath
Copy link
Contributor Author

We're making good progress on the front-end PRs. Not ready to do this yet though.

@melvin-bot melvin-bot bot removed the Overdue label Nov 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2024
@puneetlath
Copy link
Contributor Author

PR is here: https://github.com/Expensify/Web-Expensify/pull/44526. Going to do a short-lived beta just so that we can test this with a few people before rolling it out to everyone.

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
@puneetlath
Copy link
Contributor Author

All internal employees are on the beta. Now working on getting rid of the beta and making this a normal feature for everyone.

@melvin-bot melvin-bot bot removed the Overdue label Dec 9, 2024
@puneetlath puneetlath changed the title [LHN Mismatch] [HOLD #51864 and #51867] Send SetCollection instead of MergeCollection [LHN Mismatch] Send SetCollection instead of MergeCollection Dec 9, 2024
@puneetlath
Copy link
Contributor Author

This is live on production.

@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Weekly KSv2
Projects
Development

No branches or pull requests

1 participant