Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-07] [Search v1] Add bulk actions on Search #51911

Closed
luacmartins opened this issue Nov 1, 2024 · 21 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Nov 1, 2024

With this PR, we're introducing new inline actions on the Search page. The next step is to add bulk actions so users can batch process reports.

Issue OwnerCurrent Issue Owner: @lschurr / @VictoriaExpensify
@luacmartins luacmartins added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Nov 1, 2024
@luacmartins luacmartins self-assigned this Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

Triggered auto assignment to @lschurr (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Nov 1, 2024
@luacmartins luacmartins mentioned this issue Nov 1, 2024
49 tasks
@melvin-bot melvin-bot bot removed the Daily KSv2 label Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Nov 1, 2024

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Nov 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 5, 2024
@luacmartins
Copy link
Contributor Author

Draft PR is ready, but we need to hold on the inline PRs.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Nov 5, 2024
@dubielzyk-expensify
Copy link
Contributor

Any PR you want me to have a look at?

@luacmartins
Copy link
Contributor Author

@dubielzyk-expensify eventually this PR, but that's still on hold for other PRs

@dubielzyk-expensify
Copy link
Contributor

Alright. Let me know and I'll give it a review when it's ready 👍

Copy link

melvin-bot bot commented Nov 12, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@twisterdotcom twisterdotcom removed the NewFeature Something to build that is a new item. label Nov 18, 2024
@twisterdotcom
Copy link
Contributor

Relabelling as Lauren is OOO now.

@twisterdotcom twisterdotcom added the NewFeature Something to build that is a new item. label Nov 18, 2024
Copy link

melvin-bot bot commented Nov 18, 2024

Triggered auto assignment to @VictoriaExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 18, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Nov 18, 2024

Current assignee @dubielzyk-expensify is eligible for the NewFeature assigner, not assigning anyone new.

@trjExpensify
Copy link
Contributor

I know we're super close to being done here, but I'm popping it in #migrate anyway to track to completion, as making the action buttons available on the search page is central to support our plans to better support batch processing on the Search page.

Copy link

melvin-bot bot commented Nov 29, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 30, 2024
@melvin-bot melvin-bot bot changed the title [Search v1] Add bulk actions on Search [HOLD for payment 2024-12-07] [Search v1] Add bulk actions on Search Nov 30, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 30, 2024
Copy link

melvin-bot bot commented Nov 30, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 30, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-07. 🎊

For reference, here are some details about the assignees on this issue:

  • @Pujan92 requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Nov 30, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Pujan92] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@lschurr / @VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@flaviadefaria flaviadefaria moved this to First Cohort - HIGH in [#whatsnext] #migrate Dec 2, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Dec 3, 2024
@lschurr
Copy link
Contributor

lschurr commented Dec 4, 2024

Removing you Vics :)

Copy link

melvin-bot bot commented Dec 7, 2024

Payment Summary

Upwork Job

  • Reviewer: @Pujan92 owed $250 via NewDot

BugZero Checklist (@lschurr)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@lschurr
Copy link
Contributor

lschurr commented Dec 7, 2024

Payment summary is correct - please request in ND @Pujan92 :)

@lschurr lschurr closed this as completed Dec 7, 2024
@github-project-automation github-project-automation bot moved this from First Cohort - HIGH to Done in [#whatsnext] #migrate Dec 7, 2024
@garrettmknight
Copy link
Contributor

$250 approved for @Pujan92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
Development

No branches or pull requests

8 participants