Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-20] Implement attribute limitation for performance traces #52039

Closed
rinej opened this issue Nov 5, 2024 · 4 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@rinej
Copy link
Contributor

rinej commented Nov 5, 2024

Firebase Performance Monitoring has a limitation on the number of custom metadata attributes we can use for traces; it only allows up to five attributes. To work within this constraint, we need to implement a method to selectively limit which attributes are saved in Firebase, ensuring we stay within the allowed threshold.

Additionally, we need a solution that enables us to save all attributes for use in other tools, e.g. Grafana, where no such limitation exists.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 labels Nov 5, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 13, 2024
@melvin-bot melvin-bot bot changed the title Implement attribute limitation for performance traces [HOLD for payment 2024-11-20] Implement attribute limitation for performance traces Nov 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 13, 2024
Copy link

melvin-bot bot commented Nov 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @rinej does not require payment (Contractor)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 19, 2024
Copy link

melvin-bot bot commented Nov 20, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@mountiny
Copy link
Contributor

Not a bug, performance monitoring improvement, no payment, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
Development

No branches or pull requests

2 participants