Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search v2.5] Transactions without MoneyRequest preview actions are shown as not found when user tries to open them #52074

Open
luacmartins opened this issue Nov 5, 2024 · 17 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Nov 5, 2024

Problem

Coming from this thread, some expenses on policy expense chat enabled policies don't have a money request preview action created for them, which means this code fails to create a transaction thread and the user sees a not found page.

Solution

Still discussing

Issue OwnerCurrent Issue Owner: @luacmartins
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 5, 2024
@luacmartins luacmartins self-assigned this Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@isabelastisser
Copy link
Contributor

@luacmartins, does it need an internal or external assignment?

@luacmartins
Copy link
Contributor Author

We're still discussing the expected behavior. I'll update the issue once we land on a solution since that'll determine if the work is internal or external.

@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 11, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

@luacmartins, @isabelastisser Huh... This is 4 days overdue. Who can take care of this?

@isabelastisser
Copy link
Contributor

@luacmartins, any updates? Thanks!

@luacmartins
Copy link
Contributor Author

Not yet, it seems like we're migrating our policies, so hopefully this should stop happening soon.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 12, 2024
@luacmartins
Copy link
Contributor Author

Prioritizing Search actions atm. I'll try to get to this next week.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 15, 2024
@isabelastisser
Copy link
Contributor

Not overdue. ^^

Copy link

melvin-bot bot commented Nov 19, 2024

@luacmartins @isabelastisser this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Nov 19, 2024

@luacmartins, @isabelastisser Whoops! This issue is 2 days overdue. Let's get this updated quick!

@garrettmknight garrettmknight added the Internal Requires API changes or must be handled by Expensify staff label Nov 19, 2024
@luacmartins
Copy link
Contributor Author

Migration is underway. Waiting until that's done to retest this.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 19, 2024
@isabelastisser
Copy link
Contributor

Not overdue.

Copy link

melvin-bot bot commented Nov 25, 2024

@luacmartins, @isabelastisser Eep! 4 days overdue now. Issues have feelings too...

@isabelastisser
Copy link
Contributor

Hi @luacmartins, any updates here? Thanks!

@luacmartins luacmartins added Weekly KSv2 and removed Daily KSv2 labels Nov 25, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 25, 2024
@luacmartins
Copy link
Contributor Author

No updates yet. Moving this to weekly since it's an edge case

@melvin-bot melvin-bot bot added the Overdue label Dec 4, 2024
@isabelastisser
Copy link
Contributor

No updates.

@isabelastisser
Copy link
Contributor

Moving this to monthly until it can be prioritized.

@isabelastisser isabelastisser added Monthly KSv2 and removed Weekly KSv2 labels Dec 10, 2024
@melvin-bot melvin-bot bot removed the Overdue label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

3 participants