[$250] QBD - Tags show as disabled despite selecting Import as Tags in workspace config

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.58-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5184319
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: User is connected to QBD

1. In a workspace connected to QBD, navigate to Accounting > Import
2. Verify Import as tags appears for one or more coding configurations
3. Navigate to More features > Tags and notice the toggle shows disabled
4. Navigate to the LHN and notice that Tags menu item is absent

Expected Result:

If Import as Tags is selected under Accounting > Import, then More Features > Tags should show as Enabled (with lock icon) and Tags should show in the LHN.

Actual Result:

When Import as Tags is selected under Accounting > Import, More Features > Tags shows as Disabled (with lock icon) and Tags does not show in the LHN.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6656392_1730885348349.Screen_Recording_2024-11-06_at_11.57.58_in_the_morning.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021856453961383871063
• Upwork Job ID: 1856453961383871063
• Last Price Increase: 2024-11-12

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Shahidullah-Muffakir]

Edited by proposal-police: This proposal was edited at 2024-11-20 20:18:43 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Tags feature is disabled and not active on the WorkspaceMoreFeaturesPage when a user has QuickBooks Online (QBO) connected.

What is the root cause of that problem?

I think this line is causing the issue:

App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

Line 213 in 580bf69

isActive: policy?.areTagsEnabled ?? false,

What changes do you think we should make in order to solve the problem?

When user add a connection, we can set the areTagsEnabled to true for that policy.
here:

App/src/libs/actions/connections/NetSuiteCommands.ts

Line 21 in b7fdace

function connectPolicyToNetSuite(policyID: string, credentials: Omit<ConnectPolicyToNetSuiteParams, 'policyID'>) {

we can add:

    const successData: OnyxUpdate[] = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
            value: {
                areTagsEnabled: true,
            },
        },
    ]

we will do the same for all connections.

Or
We can add this useEffect in the WorkspaceMoreFeaturesPage or at the WorkspaceInitialPage so user can see the tags without opening the More Features page, which would work for all connections.

 useEffect(()=>{
        if(hasAccountingConnection&& !policy?.areTagsEnabled){
            Tag.enablePolicyTags(policyID, false);
        }
    },[policy?.areTagsEnabled,policyID,hasAccountingConnection]);

What alternative solutions did you explore? (Optional)

we can change it to :
isActive: (policy?.areTagsEnabled || hasAccountingConnection) ?? false,

[melvin-bot]

@stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

[stephanieelliott]

Confirmed this seems buggy. Adding to #expense since QBD is a control plan feature

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021856453961383871063

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[mananjadhav]

@stephanieelliott any reason this is a QBD specific bug? The reason I am asking is if Tags toggle should be enabled for the other connections?

[me-ZaidAli]

@mananjadhav are you guys still considering proposals for the issue?

[mananjadhav]

Yes open for proposals while I still have my outstanding question.

[stephanieelliott]

@stephanieelliott any reason this is a QBD specific bug? The reason I am asking is if Tags toggle should be enabled for the other connections?

No, I bet this got labeled QBD because it was one of the QBD regression tests. But in general - if Tags toggle is enabled, it should show in Workspace settings. If disabled, it should not. That goes for all integrations.

[melvin-bot]

@mananjadhav @stephanieelliott this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mananjadhav]

Still waiting for better proposals. I don't think adding accounting integration check is the correct solution.

[Shahidullah-Muffakir]

@mananjadhav, what are your thoughts on my updated proposal?

[mananjadhav]

Assigning an engineer here. I think this needs to be fixed on the backend.

🎀 👀 🎀 C+ reviewed.

[MariaHCD]

@stephanieelliott to clarify my understanding - for a workspace that is connected to any accounting integration (whether that's QBD or QBO or any other), the tags feature will be disabled and locked in More features. And so, in the Accounting settings, the tags feature should also be disabled and locked. Is my understanding correct?

@mananjadhav could you outline why you think this requires backend changes?

[MariaHCD]

Waiting on clarification on the above and then we can decide how to proceed here

[mananjadhav]

for a workspace that is connected to any accounting integration (whether that's QBD or QBO or any other), the tags feature will be disabled and locked in More features.

AFAIK it would depend on the accounting integration. For instance if Xero the tags are enabled then the More Features will show them enabled and locked.

could you outline why you think this requires backend changes?

The areTagsEnabled flag is supposed to be synced from Policy connection is populated from the backend. It could be backend or IS sync issue. May be I jumped too early but I feel this is something to be fixed from backend.

[melvin-bot]

@mananjadhav, @MariaHCD, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mananjadhav]

@MariaHCD did you get a chance to look at my comment?

[MariaHCD]

I’m still unclear on the expected behavior in this scenario and would appreciate some clarification.

For the basic case, my understanding is:

If the Tags toggle is enabled, it should appear in the Workspace settings. If disabled, it should not. This behavior applies to all integrations.

However, I’m uncertain about how this works when a policy is connected to an accounting integration. Specifically, does this mean that tags are automatically enabled? If so, should they be displayed as locked and enabled in the Workspace Settings page? Is there any integration-specific logic here? (I'm assuming not but wanted to check anyway)

cc: @stephanieelliott and @aldo-expensify (I understand you’ve worked on some of the backend logic related to enabling tags)

[aldo-expensify]

cc: @stephanieelliott and @aldo-expensify (I understand you’ve worked on some of the backend logic related to enabling tags)

From testing manually with QBO (which I think should be the same), I see that Tags is enabled by default after connecting:

In QBO the defaults settings are set in the IS server here:

https://github.com/Expensify/Integration-Server/blob/9fbb26613c260101be30ef4c045c399dbb73cb25/src/expensify/quickbooksonline/QuickbooksOnlineImporter.java#L212-L213

I'm guessing that for QBD there should be something similar (should verify).

Then, in PHP, when we are storing the connection data for the first time we, enable tags here:

https://github.com/Expensify/Web-Expensify/blob/b096b163a1313f07454405c8f508512befcea951/lib/PolicyAPI.php#L3890-L3891

This piece in PHP is only doing it for XERO and QBO, should it do it for all connections? or should we just add QBD there?

[stephanieelliott]

Sorry for the delay guys, I was out for Thanksgiving. I think we are snowballing on this issue though -- whether Tags are auto-enabled when you first connect is not really an issue, I think we can just assume that behavior is working as intended.

The Locked behavior is also not a factor here -- Tags will always show the lock icon whether enabled or disabled. This is just because you can't modify the toggle from the More Features tab, Tags must be enabled/disabled from the Accounting tab.

The actual bug is that even when Tags are enabled, Tags doesn’t appear in the LHN and the More Features > Tags setting shows as Disabled. This is a problem because it prevents users from viewing or modifying the Tags that were imported through the integration.

These images may help explain it a little better, but let me know if I can clarify this any further!

Current behavior:

Import as Tags is selected under Accounting > Import, but More Features > Tags shows as Disabled and Tags does not show in the LHN.

Expected behavior:

if Import as Tags is selected under Accounting > Import, then More Features > Tags should show as Enabled and Tags should show in the LHN.

[melvin-bot]

@mananjadhav @MariaHCD @stephanieelliott this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[mananjadhav]

Thanks @stephanieelliott. This comment makes sense. Will you be able to update the GH issue body? I think the important step is that the Workspace > Import > Any of the options have imported as tags, yet the More Features > Tag shows disabled with lock. This should've been shown as enabled with lock.

I'll investigate this but also open for proposals now.

[stephanieelliott]

I think the important step is that the Workspace > Import > Any of the options have imported as tags, yet the More Features > Tag shows disabled with lock. This should've been shown as enabled with lock.

Yep, exactly @mananjadhav! I will update the issue body to make this more clear

[stephanieelliott]

Just spot checked and it looks like this is still occurring. It is isolated to QBD though, not seeing it with other integrations.

[mananjadhav]

Yes because I checked Netsuite and Xero. It worked fine. I don't have QBD setup and I am setting it up.

@stephanieelliott Would it be possible for you to share the policy JSON from your local browser? To verify the data + conditions we have.

[melvin-bot]

@mananjadhav, @MariaHCD, @stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mananjadhav]

Still waiting for proposals.

[mananjadhav]

Still waiting for proposals.

[MariaHCD]

Not overdue - still awaiting proposals