-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-03] [$125] Share Code - Inconsistent profile pic shape in admin room when accessed via #Admin hyperlink #52258
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
Reproduced. 2024-11-08_14-45-28.mp4 |
Job added to Upwork: https://www.upwork.com/jobs/~021854973788673857466 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 ( |
Seems like a pretty minor bug, so bumping down. |
Upwork job price has been updated to $125 |
ProposalPlease re-state the problem that we are trying to solve in this issue.When users view shared QR codes in the Expensify app, the profile picture shape is inconsistent depending on the navigation path taken. Specifically:
What is the root cause of that problem?The issue occurs because when the user clicks on the hyperlink here: What changes do you think we should make in order to solve the problem?When the user clicks on the hyperlink, close the current modal before navigating to the new page. This can be done using the Navigation.dismissModal() method.
|
Thanks @Shahidullah-Muffakir for the proposal, the RCA checks out and the proposed solution fixes the issue in accordance with the Expected result. SuggestionIn order to DRY the code down to one line you might as well write it like this: Navigation.dismissModal(adminRoom.reportID); since App/src/libs/Navigation/dismissModalWithReport.ts Lines 24 to 29 in c75b1bc
🎀👀🎀 C+ reviewed |
Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@ikevin127, Thank you for pointing that out! We’ll use that. |
CME doesn't seem to be OOO, not sure what's the hold up here. cc @grgia @joekaufmanexpensify for visibility. |
@grgia mind signing off on this one when you have a sec? |
@joekaufmanexpensify Do you think it's possible to re-assign CME for this issue ? Must be caught-up with some higher priority tasks and we wouldn't want deter from that. There's another issue reported on Slack with the same situation here. |
📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @Shahidullah-Muffakir You have been assigned to this job! |
PR in review |
Awaiting final PR review from @grgia |
♻️ Status updaate: PR was merged & deployed to staging and is now awaiting production deploy. |
Sounds good. TY! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-03. 🎊 For reference, here are some details about the assignees on this issue:
|
@ikevin127 @joekaufmanexpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
Regression Test Proposal
Do we agree 👍 or 👎. |
Great. I will handle next steps! |
@Shahidullah-Muffakir offer sent for $125! |
This is a pretty niche bug, I don't think we need a regression test everytime here. |
All set to pay:
|
@ikevin127 $125 sent and contract ended |
@Shahidullah-Muffakir $125 sent and contract ended |
Upwork job closed. |
All set, thanks everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: NA
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The profile picture should consistently appear as a circle
Actual Result:
When navigating to the admin room share code through the #admin hyperlink, the profile picture appears as a rectangle
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6658801_1731068758423.1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @joekaufmanexpensifyThe text was updated successfully, but these errors were encountered: