[HybridApp] Update the force upgrade modal to distinguish between prod and staging environments.

[trjExpensify]

Coming from here.
Parent issue

Problem

When we deprecate the NewDot standalone app, it causes us to not be able to test whether bugs are /app or /mobile, which prevents us from confirming if the issue can be external or internal.

Why is this important?

To protect internal engineering resources and maximise the use of our external contributors. This is also a blocker to deprecating the app, which increasingly causing more confusion amongst users.

Solution

• Update the force upgrade modal to distinguish between staging and production environments.
• Force upgrade production only, pointing the "Upgrade" CTA to the "Expensify" HybridApp listing in the app store.

In doing so, we can continue shipping NewDot standalone builds to staging environments (i.e Testflight) and maintain our ability to test for HybridApp only bugs.

Issue Owner

Current Issue Owner: @trjExpensify

[trjExpensify]

Asking about next steps here. CC: @staszekscp

[staszekscp]

Just to confirm the scope of the task 😄 The desired behaviour is to:

1. Present the Force upgrade modal to production users on NewDot, with a CTA to download HybridApp
2. Distinguish production and staging on HybridApp (since we don't do it at the moment)

[trjExpensify]

I don't think (2) is required for this issue. We need to force upgrade production users of the NewDot app, and keep shipping new builds to staging such that we can continue testing bugs to determine if they're HybridApp only or not.

[staszekscp]

In this case I think we can take care of that when we'll align the HybridApp deployment to NewDot! When it happens we can take care of that, so it doesn't happen to soon 😄

[trjExpensify]

Cool, I think we just merged that PR didn't we? #52283

[staszekscp]

Ok then! We'll jump into this on Monday!

[Julesssss]

Hey @staszekscp, is there anyone specifically that I can assign this issue to?

[war-in]

Hi @Julesssss 👋 I'm going to work on this :)

[Julesssss]

Great, let me know if I can help with anything.

[Julesssss]

@trjExpensify we should think about testing. It's going to be tricky so maybe we just have to manually verify on the PR that bumps the minimum once these changes are deployed and we are ready to kill standalone?

[trjExpensify]

Hm yeah, I'm not actually sure how to test that beforehand on staging, given it's a solution to force upgrade production only. When we deploy to staging the PR to bump the minimum version, could we minimally test that staging environments aren't blocked? 🤔

[AndrewGable]

I think we should add a beta to test this, so we can confirm on known test domains and then enable it for all domains.

[AndrewGable]

Added in https://github.com/Expensify/Web-Expensify/pull/44480, the beta name will be hybridForcedMigration

[Julesssss]

PR merged, awaiting deployment for testing

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Update force upgrade modal #52703

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

• @war-in does not require payment (Contractor)

[trjExpensify]

@Julesssss can we close this?

[Julesssss]

@trjExpensify I want to keep it open a bit longer as it hasn't been tested properly yet. It can be closed as soon as internal QA occurs for this backend PR.

[trjExpensify]

Works for me!

[trjExpensify]

We're still waiting to confirm this, Melv.

[melvin-bot]

@Julesssss, @trjExpensify, @war-in Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

Still held up on confirming this.

[melvin-bot]

@Julesssss, @trjExpensify, @war-in Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Julesssss]

• InternalQA staging passed yesterday: https://github.com/Expensify/Web-Expensify/pull/44699#issuecomment-2539486808
• InternalQA prod is being tested this morning (internal plan)