Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expensify Card - No error message when incorrect code is entered when deactivating card #52338

Closed
4 of 8 tasks
lanitochka17 opened this issue Nov 11, 2024 · 8 comments
Closed
4 of 8 tasks
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.60-0
Reproducible in staging?: Y
**Reproducible in production?:**N, New feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Slack conversation (hyperlinked to channel name):

Issue found when executing PR #51147

Action Performed:

Precondition:

  • User has a virtual card
  1. Go to staging.new.expensify.com
  2. Go to Wallet
  3. Click on the virtual card
  4. Click Report virtual card fraud
  5. Click Deactivate card
  6. Enter incorrect magic code

Expected Result:

There will be error for incorrect magic code

Actual Result:

There is no error for incorrect magic code.
App shows not here page briefly and then empty card details page loads

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6661758_1731354317140.20241112_034102.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 11, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 11, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

lanitochka17 commented Nov 11, 2024

New feature, not repro on Production

bandicam.2024-11-11.15-55-42-076.mp4

@francoisl francoisl added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 11, 2024
@francoisl
Copy link
Contributor

This will require backend changes, reassigning and demoting.

@melvin-bot melvin-bot bot added the Overdue label Nov 14, 2024
@francoisl francoisl added the Reviewing Has a PR in review label Nov 15, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 15, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

@francoisl, @youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@francoisl
Copy link
Contributor

I think the last piece was https://github.com/Expensify/Auth/pull/12739 and we can close this now, right @youssef-lr?

@youssef-lr
Copy link
Contributor

Yup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants