Unable to Delete receipt after "Replace" is used by Admin

[OfstadC]

Original GH: #50113 (comment)

Action Performed:

1. From an employee account - navigate to the workspace chat and click + > Submit Expense > Scan Receipt > Complete submit flow
2. Login as admin
3. Click on the receipt thumbnail
4. Click on "Replace" > Choose another receipt or take a photo of it > Upload
5. "Delete" > Confirm > Notice that an error is thrown
6. An error is shown: 'Unexpected...'

Expected Result:

We should to two things here:

• Enable replace functionality on backend so that admins and managers can replace receipts -- Here's the logic that will need to be updated:
• Remove delete button for managers/admins, but keep the delete button for submitters -- this can be done as part of the front-end issue

---

Screenshots/Videos

I didn't grab a new video when I reproduced this afternoon - but will grab one first thing tomorrow morning

jsonCode
:
405
message
:
"405 Cannot detach receipt from unowned transaction"
onyxData
:
[]
requestID
:
"8e109b54d92daccc-MSP"

Logs

Add any screenshot/video evidence

Issue Owner

Current Issue Owner: @Julesssss

[melvin-bot]

Triggered auto assignment to @Julesssss (AutoAssignerNewDotQuality)

[tgolen]

FYI there was also this very small thread in Slack where we were talking about the expected behavior. So, if we are still questioning what the functionality should be, please respond in that thread.

[Julesssss]

The steps are correct. As discussed we want to allow admins to detach receipts in NewDot. Though I have asked here to clarify, as we may only want to support the replace case.

Here's the logic that will need to be updated:

// Managers and admins cannot detach receipts unless they own the expense,
// but they can merge transactions within the same report.
if (!receiptID && !isManagerOrAdminMerging && (isManagerOrAdminAttaching && !canUserAttach)) {
    STHROW("405 Cannot detach receipt from unowned transaction");
}

[Julesssss]

Expected behaviour verified, we should to two things here:

• Enable replace functionality on backend so that admins and managers can replace receipts -- Here's the logic that will need to be updated:
• Remove delete button for managers/admins, but keep the delete button for submitters -- this can be done as part of the [HOLD for #52345][$250] Scan - "Delete" and "Replace" options are displayed for an admin which causes an error #50113

I have updated the issue description

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[garrettmknight]

@Julesssss if you're gonna unassign can you make sure a BZ member is on it in the future?

[Julesssss]

Ah sure. I thought that was only necessary for external issues? We already have an external issue #50113 for the front-end changes. LMK if I'm mistaken though

[joekaufmanexpensify]

Yeah, I am also curious about this. If there is nothing contributor-related to do here because of the separate FE issue, I feel like a BZ might not be needed. But also not sure if there is a defined process for this. Curious to hear what @garrettmknight thinks as well

[garrettmknight]

That's fair - I missed the external issue. Equally, this is kind of a weird pattern where we have an external issue on hold + an unassigned internal issue that melvin will probably continue to degrade until it closes. Maybe a good follow up there - why unassign this instead of implementing the fix you identified?

[melvin-bot]

@joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Julesssss]

I unassigned because unless I am mistaken; A) Engineers must triage but not necessarily implement auto-assigned engineering issues (including quality), and B) this is lower priority than other k2 issues, which include quality and migrate issues that will probably keep me busy until the end of the year.

Agree with this being a weird case, Matt Allen and I discussed this a bit here#49162 (comment).

[joekaufmanexpensify]

I also am a bit confused why we wouldn't just manage the backend portion of this bug in the original issue? This is also just an app issue. Seems more efficient to handle both in one issue (if they're both app issues), rather than work on two halves of the same bug separately.

[Julesssss]

I'm working on external/internal issues that are going to take a while. Just noting for future reference that this is unlikely to be picked up until 2025

[twisterdotcom]

I am removing hot pick from any issues with an internal engineer assigned so other engineers can know it's unavailable/taken.

[melvin-bot]

@Julesssss, @joekaufmanexpensify Eep! 4 days overdue now. Issues have feelings too...

[Julesssss]

Same as above. I might share this with Garrett to list as an #expense issue that is looking for a volunteer

[Julesssss]

I shared in the #expense channel here.

[joekaufmanexpensify]

TY!

[melvin-bot]

@Julesssss, @joekaufmanexpensify Huh... This is 4 days overdue. Who can take care of this?

[Julesssss]

Awaiting volunteers. @garrettmknight if you don't mind, could you please highlight this backend issue in your next #expense roundup? We just need someone with no assigned issue to implement this new logic.

we want to allow admins to detach receipts in NewDot

[joekaufmanexpensify]

Moving this one to weekly for now as I am OOO after today through new years and I see you are as well!

[joekaufmanexpensify]

OOO this week, we will circle back next week

[Julesssss]

We're seeking a volunteer for this one internally

[Julesssss]

No volunteer yet. Will ask again next week. I have higher priority issues to work on currently.

[garrettmknight]

@Julesssss dropping you off in case anyone is looking for Hot Picks and thinks you're handling.