Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make search page actions more fun with animations #52372

Open
JmillsExpensify opened this issue Nov 12, 2024 · 7 comments
Open

Make search page actions more fun with animations #52372

JmillsExpensify opened this issue Nov 12, 2024 · 7 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Overdue Weekly KSv2

Comments

@JmillsExpensify
Copy link

We've on the cusp of adding animations for pay and approve via this issue, which is super cool. We're also very close to merging a PR for approve/pay report actions on the Search page. Here's how Search approvals look today (this is the bulk case, you can also approve or pay a report individually).

CleanShot 2024-11-12 at 11 33 41

@Expensify/design Shall we use the exact same animations from #49847 on the Search page as well? Let's use this issue to hash things out.

@JmillsExpensify JmillsExpensify added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Nov 12, 2024
@JmillsExpensify JmillsExpensify self-assigned this Nov 12, 2024
Copy link

melvin-bot bot commented Nov 12, 2024

Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Nov 12, 2024
Copy link

melvin-bot bot commented Nov 12, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Nov 12, 2024

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 21, 2024
@JmillsExpensify
Copy link
Author

Not the highest priority but still on the list when the design team has a free moment

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
@shawnborton
Copy link
Contributor

Will try to take a look at this one this week, sorry for the delay!

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2024
@shawnborton
Copy link
Contributor

Sorry, no progress yet.

@melvin-bot melvin-bot bot removed the Overdue label Dec 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 25, 2024
@shawnborton
Copy link
Contributor

No update

@melvin-bot melvin-bot bot removed the Overdue label Dec 27, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Overdue Weekly KSv2
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

2 participants