Invoices Category visible for invoice recipient in the Search LHN

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #52148
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition: User signed into account A on the main tab and into account B, which is not a member of any workspace with invoices and has never released files, in the incognito tab

1. [Account A] open https://staging.new.expensify.com/

2. [Account A] Create a workspace and enable invoices

3. [Account B] Navigate to search tab and observe categories

4. [Account A] Send invoice to account B

5. [Account B] Repeat step 3

Expected Result:

According the step 10 in the PR, "Veriy that invoices category is not visible in the Search LHN"
(Invoices categories should not be displayed in the search tab for invoice recipient in the Search LHN)

Actual Result:

Invoices Category visible for invoice recipient in the Search LHN

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6661868_1731361613307.Screen_Recording_2024-11-11_at_23.26.59.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[NJ-2020]

I think we should show the invoice category menu if the user has invoices report
But if we don't want to show the invoice category menu we can simply remove this check hasInvoiceReports()

App/src/pages/Search/SearchTypeMenu.tsx

Line 96 in cd3f30f

if (hasWorkspaceWithInvoices(session?.email) || hasInvoiceReports()) {

[rushatgabhane]

not a bug. it is expected that invoices will be seen if the user has received invoices

[luacmartins]

This is expected. The invoice receiver should be able to filter by invoices since they have invoices in their account. Closing