[HOLD for payment 2024-11-28] Web - Pay someone-Wallet page displayed in central pane instead of 1:1 chat after validating account

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.61.0
Reproducible in staging?: Y
Reproducible in production?: Not repro in Prod, App logging out
Issue was found when executing this PR: #50835
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/ and log in with a new account
2. Select Something else on the onboarding modal
3. Click on FAB > Start chat and enter an email of another user
4. In 1:1 chat click on + > Pay someone
5. Enter the amount and proceed to the next step
6. Select Pay with Expensify
7. Enter correct code

Expected Result:

1:1 chat is still displayed in the central pane

Actual Result:

Wallet page is displayed in the central pane instead of 1:1 chat

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6663364_1731472487738.Recording__946.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Production has the following behaviour

bandicam.2024-11-13.06-52-45-471.mp4

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pay someone-Wallet page displayed in central pane instead of 1:1 chat after validating account

What is the root cause of that problem?

We are not passing backTo route here

App/src/components/SettlementButton/index.tsx

Line 194 in 4d9be4e

Navigation.navigate(ROUTES.SETTINGS_WALLET_VERIFY_ACCOUNT.route);

What changes do you think we should make in order to solve the problem?

We should add backTo route here. We can do something like this here

 if (!isUserValidated) {
                const activeRoute = Navigation.getActiveRoute();
                Navigation.navigate(ROUTES.SETTINGS_WALLET_VERIFY_ACCOUNT.getRoute(activeRoute));
                return;
            }

What alternative solutions did you explore? (Optional)

[arosiclair]

Let's not block on this since it's not really a regression. I'll take over and make sure this gets cleaned up.

[arosiclair]

This should be simple to fix so I'll do it internally

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix validate page navigation #52603

If no regressions arise, payment will be issued on 2024-11-28. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

@c3024 @muttmuure @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @c3024 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@muttmuure)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[muttmuure]

@c3024 - $250 C+

[melvin-bot]

@arosiclair, @muttmuure, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[c3024]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: f7310b1#r149812246

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not critical enough to start a discussion

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• None

Test:

1. Log in with a new account
2. Open a chat with another user
3. Click + > Pay someone
4. Enter the amount
5. Select Pay with Expensify
6. Enter the correct magic code in the verification modal and verify.
7. Verify that you're navigated back to the payment page
8. Verify that the Central pane still displays the chat
9. Go to Settings > Wallet > Add bank account
10. Enter the correct magic code in the verification modal and verify.
11. Verify that you're navigated back to the bank account addition page and central pane does not change.
12. Go to Settings > Wallet > Enable wallet
13. Enter the correct magic code in the verification modal and verify.
14. Verify that you're navigated back to the enable wallet page and central pane does not change.

Do we agree 👍 or 👎

[melvin-bot]

@arosiclair, @muttmuure, @c3024 Huh... This is 4 days overdue. Who can take care of this?

[muttmuure]

@c3024 the payment date is on the day you are eligible for payment on New Expensify. Are you planning on submitting your request there?

[c3024]

Yes. @sonialiap is in the process of adding me to ND payments workspace. Thanks!

[sonialiap]

@c3024 you've been added on our end 🎉 I sent an email with some steps to you yesterday. Please take a look and follow the steps outlined there. Let me know if you have any questions!

[c3024]

Requested on ND.

[melvin-bot]

@arosiclair, @muttmuure, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

$250 approved for @c3024 based on this summary.

[melvin-bot]

@arosiclair, @muttmuure, @c3024 Eep! 4 days overdue now. Issues have feelings too...