Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Focus Mode popup is not closed by device back button #52467

Closed
1 of 8 tasks
IuliiaHerets opened this issue Nov 13, 2024 · 4 comments
Closed
1 of 8 tasks

Web - Focus Mode popup is not closed by device back button #52467

IuliiaHerets opened this issue Nov 13, 2024 · 4 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.61-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #52072
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. In an account with "Focus" mode enabled, change the mode to "Most Recent"
  2. Type "Onyx.set("focusModeNotification",true);" in console and get focus mode notification instantly
  3. Use device back button try to close focusMode popup

Expected Result:

Using device back button when focusMode popup is visible, focusMode popup should be closed.

Actual Result:

FocusMode popup is not closed by device back button.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6663392_1731475560332.bandicam_2024-11-13_08-09-00-095.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 13, 2024
Copy link

melvin-bot bot commented Nov 13, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@FitseTLT
Copy link
Contributor

This might be expected as for web the modal should close on press of esc only

// Note: Escape key on web/desktop will trigger onBackButtonPress callback

@ChavdaSachin
Copy link
Contributor

ChavdaSachin commented Nov 13, 2024

Yes this is expected here, Backspace button on keyboard does not count as device back button.
Despite see

#52072 (comment)

Test 2.

  1. Get focusModeNotification (steps mentioned above).
  2. Use device back button when focusMode popup is visible and verify focusMode popup is closed.

(Test 2 might not work on web and mweb see #51432 (comment) and #51432 (comment))

So right now Test 2 is super specific to Android Native.

@lschurr
Copy link
Contributor

lschurr commented Nov 13, 2024

Closing since this is expected behavior.

@lschurr lschurr closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants