Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-03] Update copy on custom feed details page #52581

Closed
joekaufmanexpensify opened this issue Nov 14, 2024 · 13 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@joekaufmanexpensify
Copy link
Contributor

joekaufmanexpensify commented Nov 14, 2024

Coming from here, we want to update the copy on these two pages because it is currently confusing.

Visa changes

  • Update copy in first paragraph to: We have global integrations with Visa, though eligibility varies by bank and card program.
  • Add a space in 2 between to and enable as it's missing one right now.
image

Mastercard change

  • Update copy in first paragraph to: We have global integrations with Mastercard, though eligibility varies by bank and card program.
image
Issue OwnerCurrent Issue Owner: @abekkala
@joekaufmanexpensify joekaufmanexpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@joekaufmanexpensify
Copy link
Contributor Author

Someone from callstack will likely pick this up, flagging in Slack!

@mountiny
Copy link
Contributor

Spanish translations:

We have global integrations with Visa, though eligibility varies by bank and card program. > Contamos con integraciones globales con Visa, aunque la elegibilidad varía según el banco y el programa de la tarjeta.

We have global integrations with Mastercard, though eligibility varies by bank and card program. > Contamos con integraciones globales con Mastercard, aunque la elegibilidad varía según el banco y el programa de la tarjeta.

@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2024
@mountiny
Copy link
Contributor

will look

@melvin-bot melvin-bot bot removed the Overdue label Nov 18, 2024
@narefyev91
Copy link
Contributor

@mountiny I can pick this up

@mountiny
Copy link
Contributor

no c+ needed here

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 18, 2024
@narefyev91
Copy link
Contributor

@mountiny #52708 ready

@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 19, 2024
@garrettmknight garrettmknight added the Internal Requires API changes or must be handled by Expensify staff label Nov 19, 2024
@DylanDylann
Copy link
Contributor

@mountiny Could I help to speed up the PR?

@mountiny
Copy link
Contributor

@DylanDylann all good on this one

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 26, 2024
@melvin-bot melvin-bot bot changed the title Update copy on custom feed details page [HOLD for payment 2024-12-03] Update copy on custom feed details page Nov 26, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 26, 2024

@mountiny @abekkala @narefyev91 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

this was just a copy change and nobody to pay here so I think we can close

@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in [#whatsnext] #expense Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

6 participants